[Github Actions] Add test for AWS builder #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any chance we can get automatic start going by early next week (01/20). |
Done. |
|
Tests run correctly, start-instance does the right thing (start when stopped, nothing when running), shutdown script does the right thing. We can disable the old graviton tests now and start moving all other tests to github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix to move to Github Actions. It does not start/stop the instance automatically, this is left for later once we get the IAM/secret keys right, but it works as a temporary stop-gap for now.
I have added triggers for
workflow_dispatch(ie. press the button on Github's web interface) andpush(which also counts PRs). This means for now we still need to activate the instance whenever it runs, so we could keep only onworflow_dispatchand notpush?I don't mind either way.