chore(ci) : update dependencies and define caches #385
Conversation
mmorel-35
commented
Aug 20, 2021
mmorel-35
commented
- setup dependabot
- update current dependencies
- define caches for cabal, go , gradle, pip, spm
- setup dependencies - define caches for cabal, go , gradle, pip, spm Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-Authored-By: Matthieu MOREL <mmorel-35@users.noreply.github.com>
|
👋 @mmorel-35 thanks for opening this. Adding dependabot is 👍 in general, though I'm curious if there is any context around this update since the PR body is pretty sparse. Were you finding any issues with the tool as-built? Or is this preventative for future updates? |
|
Hi ! There was no issue. I like the tool. I just want to help the project to spare time in the developement. With the bot you just validate the triggered PR/ or fix it / or reject it and with the caches, you can do more builds in the same time . |
There was a problem hiding this comment.
thanks for making this change - I left a few requests to have greater specificity in the cache keys. This tool's entire purpose is to work across a range of versions on a range of package managers and languages, and I've been surprised in the past at things going wrong between different versions of the language or package manager being used.
I'm similarly wary of the use of the restore keys that can potentially cause dangerous cache sharing. I didn't add them in the past based on the same ☝️ concerns. It's probably fine to try out and if re-evaluate if anything comes up though 🤷
| name: cache pip dependencies | ||
| with: | ||
| path: ~/.cache/pip | ||
| key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements.txt') }} |
There was a problem hiding this comment.
same here - this might need to include ${{ matrix.python }} as part of the key and restore key
| name: cache spm dependencies | ||
| with: | ||
| path: .build | ||
| key: ${{ runner.os }}-spm-${{ hashFiles('**/Package.resolved') }} |
There was a problem hiding this comment.
and same here with ${{ matrix.swift }}
|
Hi! I will follow your préconisations. |
Co-authored-by: Jon Ruskin <jonabc@github.com>
Is there anything specific you had in mind that was missing? |
|
I was thinking of documentation completion. For example with the cabal cache, there is no hashed file in the documentation as it can be seen for many other languages and tools |
|
Ah got it. Maybe that's something you'd like to open a PR on the actions/cache repo to update? In any event, this change is looking good, thanks for opening this up and keeping things running smoothly 🙇 |
thanks!
## 3.2.1 2021-09-06 ### Changed - Updated multiple dependency versions (:tada: @mmorel-35 #385, #389) - Go homepage links use pkg.go.dev instead of godoc.org (:tada: @mmorel-35 73cfbbe) - Local development ruby version changed to 2.7.4 (#393) ### Fixed - Bundler source correctly finds platform specific dependencies (#392)
