Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Flocking synths follow Infusion's model semantics #252

Closed
colinbdclark opened this issue Nov 2, 2018 · 0 comments
Closed

Ensure Flocking synths follow Infusion's model semantics #252

colinbdclark opened this issue Nov 2, 2018 · 0 comments

Comments

@colinbdclark
Copy link
Collaborator

There is still some leftover "model bashing"—direct assigning to model values, etc. in Flocking's synth implementation. Also, the implementation of different types of synths in Flocking is inconsistent and confusing. This makes it hard to, for example, use Flocking synth's in Aconite to modulate video parameters or shader uniforms.

Flocking should be refactored to properly use Infusion's ChangeApplier where appropriate, and to avoid direct model bashing where not.
colinbdclark added a commit that referenced this issue Nov 18, 2018
@colinbdclark
gh-252: Moves synth-related grades into separate files.
8da98c4
colinbdclark added a commit that referenced this issue Nov 19, 2018
@colinbdclark
gh-252: Updates tests for synth restructuring and removal of input().
da839dd 
Renames Synth.genFn to generate().
colinbdclark added a commit that referenced this issue Nov 27, 2018
@colinbdclark
Merge branch 'gh-252'
4577823 
* gh-252:
  Fixes gh-252: Regularizes synth evaluation. Removes pseudo-modelism. Removes remaining uses of .input(); renames Synth.gen to generate.
  gh-252: Updates tests for synth restructuring and removal of input(). Renames Synth.genFn to generate().
  gh-252: Moves synth-related grades into separate files.
colinbdclark added a commit that referenced this issue Nov 27, 2018
@colinbdclark
Merge branch 'master' into remove-nodejs-support
4def575 
* master:
  Fixes gh-252: Regularizes synth evaluation. Removes pseudo-modelism. Removes remaining uses of .input(); renames Synth.gen to generate.
  gh-252: Updates tests for synth restructuring and removal of input(). Renames Synth.genFn to generate().
  gh-252: Moves synth-related grades into separate files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinbdclark