Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception from upgrade_to_bot_account() #1030

Conversation

MarkZH
Copy link
Collaborator

@MarkZH MarkZH commented Oct 5, 2024

Type of pull request:

  • Bug fix
  • Feature
  • Other

Description:

The call to Lichess.upgrade_to_bot_account() does not return a value. Failure is signaled by an exception. Fix the call to upgrade_account() in lib/lichess_bot.py to reflect this.

Related Issues:

Fixes #1029

Checklist:

  • I have read and followed the contribution guidelines.
  • I have added necessary documentation (if applicable).
  • The changes pass all existing tests.

Screenshots/logs (if applicable):

N/A

The call to Lichess.upgrade_to_bot_account() does not return a value. Failure is signaled by an exception. Fix the call to upgrade_account() in lib/lichess_bot.py to reflect this.
@AttackingOrDefending AttackingOrDefending merged commit ccde168 into lichess-bot-devs:master Oct 7, 2024
15 checks passed
@MarkZH MarkZH deleted the bot-upgrade-error-handling branch October 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First attempt to upgrade to bot account shows failure message
2 participants