Delay engine and book downloads until needed for a test #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, - Since the Sjeng site seems unreliable recently, skip the test if the download fails. - Use a local logger instead of the one from lichess_bot.
|
I think we should give tests around 15 more seconds to finish to account for the extra time taken to download the engines. |
In case the tests are run in a different order.
Since stockfish is used as the opponent in all engine tests, make sure it exists in case the tests are run in a different order.
AttackingOrDefending
approved these changes
Oct 14, 2024
AttackingOrDefending
merged commit 4909a8e
into
lichess-bot-devs:master
21 checks passed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
This PR delays downloading the chess engines used for testing until the test that uses them actually runs. This way, the test script can start faster and run the downloads in parallel. Plus, any tooling that reads the test file (VS Code plugins that track test completion) does not have to wait for engine/book downloads.
Another change is to skip a test when an engine or book download fails instead of failing it. The Sjeng website seems to have been down for several weeks now. GitHub actions still works because it's retained a cached copy.
Finally, a logger instance local to test_bot.py is used instead of importing the one from lichess_bot.py.
Related Issues:
N/A
Checklist:
Screenshots/logs (if applicable):
N/A