Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add symmetric piece set #51

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

tom-anders
Copy link
Contributor

Generated from lichobile code by (temporarily) slightly adapting scripts/convert_svgs_to_pngs.sh

@veloce
Copy link
Collaborator

veloce commented Aug 29, 2024

Looks like there are missing assets for 2.0X and 3.0X resolutions.

@tom-anders
Copy link
Contributor Author

Looks like there are missing assets for 2.0X and 3.0X resolutions.

Are you sure?

❯ git ls-files assets/piece_sets/symmetric
assets/piece_sets/symmetric/2.0x/bB.png
assets/piece_sets/symmetric/2.0x/bK.png
assets/piece_sets/symmetric/2.0x/bN.png
assets/piece_sets/symmetric/2.0x/bQ.png
assets/piece_sets/symmetric/2.0x/wB.png
assets/piece_sets/symmetric/2.0x/wK.png
assets/piece_sets/symmetric/2.0x/wN.png
assets/piece_sets/symmetric/2.0x/wP.png
assets/piece_sets/symmetric/2.0x/wQ.png
assets/piece_sets/symmetric/2.0x/wR.png
assets/piece_sets/symmetric/3.0x/bB.png
assets/piece_sets/symmetric/3.0x/bK.png
assets/piece_sets/symmetric/3.0x/bN.png
assets/piece_sets/symmetric/3.0x/bQ.png
assets/piece_sets/symmetric/3.0x/bR.png
assets/piece_sets/symmetric/3.0x/wB.png
assets/piece_sets/symmetric/3.0x/wK.png
assets/piece_sets/symmetric/3.0x/wN.png
assets/piece_sets/symmetric/3.0x/wP.png
assets/piece_sets/symmetric/3.0x/wR.png
assets/piece_sets/symmetric/4.0x/bB.png
assets/piece_sets/symmetric/4.0x/bK.png
assets/piece_sets/symmetric/4.0x/bN.png
assets/piece_sets/symmetric/4.0x/bP.png
assets/piece_sets/symmetric/4.0x/bQ.png
assets/piece_sets/symmetric/4.0x/bR.png
assets/piece_sets/symmetric/4.0x/wB.png
assets/piece_sets/symmetric/4.0x/wK.png
assets/piece_sets/symmetric/4.0x/wN.png
assets/piece_sets/symmetric/4.0x/wP.png
assets/piece_sets/symmetric/4.0x/wQ.png
assets/piece_sets/symmetric/4.0x/wR.png
assets/piece_sets/symmetric/bB.png
assets/piece_sets/symmetric/bK.png
assets/piece_sets/symmetric/bN.png
assets/piece_sets/symmetric/bP.png
assets/piece_sets/symmetric/bQ.png
assets/piece_sets/symmetric/bR.png
assets/piece_sets/symmetric/wB.png
assets/piece_sets/symmetric/wK.png
assets/piece_sets/symmetric/wN.png
assets/piece_sets/symmetric/wP.png
assets/piece_sets/symmetric/wQ.png
assets/piece_sets/symmetric/wR.png

@tom-anders
Copy link
Contributor Author

Oh now I see it, sorry, assets/piece_sets/symmetric/2.0x/bP.png is missing for example, I'll have a look

Generated from lichobile code by slightly adapting scripts/convert_svgs_to_pngs.sh
@tom-anders
Copy link
Contributor Author

Ok, apparently the problem was that scripts/convert_svgs_to_pngs.sh would run multiple inkscape instances in parallel, which for some reason lead to a few files being missed. Removing the & fixed this.

git ls-files assets/piece_sets/symmetric | wc -l now yields 48 (2 * 6 * 4), so all the images should be there now

@veloce veloce merged commit 032aea7 into lichess-org:main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants