Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS class for the selected pocket piece #14052

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VVestin
Copy link

@VVestin VVestin commented Nov 20, 2023

fixes #12866
This change depends on this PR to lichess-org/chessground:
lichess-org/chessground#292

This is the styling I propose for the selected piece:
image

I'm definitely open to other ideas on how we should style the selected piece.
I copied that color from the selected piece background in chessground.
A similar style we use on the pocket is what we do for the pre-dropped piece where we highlight the background a shade of gray.

@kraktus
Copy link
Member

kraktus commented Nov 28, 2023

Hey, thanks for the work, is this PR a draft due to work on your side pending, or because you're waiting for feedback?

package.json Outdated Show resolved Hide resolved
@VVestin
Copy link
Author

VVestin commented Nov 29, 2023

Hey, thanks for the work, is this PR a draft due to work on your side pending, or because you're waiting for feedback?

No, this is the only change I intend to make. It's a draft until the chessground PR gets merged: lichess-org/chessground#292.
(Also, I just realized the link I made in the original comment was broken! Fixed it now)

Is this the right way to handle linked changes? This was the advice I got on the lichess discord.

@TheForkPower
Copy link
Contributor

@VVestin yes it is! Is this ready to merge?

@VVestin
Copy link
Author

VVestin commented Jan 16, 2024

@VVestin yes it is! Is this ready to merge?

No, still waiting on the chessground PR to be merged:
lichess-org/chessground#292

Maybe I should reach out to @niklasf or @ornicar to take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crazyhouse drops by click-click
3 participants