-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix html tags in blog post #16314
base: master
Are you sure you want to change the base?
Fix html tags in blog post #16314
Conversation
Hey, thanks for the PR! Reading back my comment I see how I could be misread, but we do not want to support arbitrary HTML in blog post due to security/XSS concern. We rather want to disable the preview WYSIWYG editor. |
Hey @kraktus! That make sense. I updated the toast-ui editor styling to hide the write/preview button container, since the editor does not have an option to disable the preview tab. |
Thanks! That's better already, can we just hide HTML rendering in the preview instead of the preview altogether? |
Updated to escape html tags when the preview button is clicked. https://www.loom.com/share/ab90f5980905400687be3a426ca16b61?sid=e5743dad-9131-4b03-a10a-632c22447251 |
I think it's weird that clicking "preview" effectively modifies the text. I would expect a preview to be without side effects. |
I was hoping an option to disable html preview in toastui-editor options, but judging by nhn/tui.editor#679 it does not seem possible and should really be something fixed at this level |
Actually maybe looking at |
The |
Resolves: #16256
Uses CSS to hide the write / preview button container in the markdown editor