import as type and use named imports when possible #16387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEN
,Role
,Key
,Dests
,Piece
,Color
,Files
,Ranks
from chessground/types provided in global namespace via @types/lichessimport type
whenever possibleit's never a bad idea to always import types like
{ type MyType }
and prefer named imports as sometimes it can avoid including unnecessary code, although this is far less important now with code splitting.this PR does reduce the overall assets downloaded on most pages (slightly). that's a consequence of reduced bundling due to import changes. it has some insignificant edits to speech/voice but aside from that, javascript should be the same. only types and names were changed - it's much safer than it probably looks.