Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid explorer network call when gamebook play mode #16902

Closed

Conversation

cmgchess
Copy link
Contributor

fix #16890

not sure if this is the correct approach though

@ornicar
Copy link
Collaborator

ornicar commented Jan 31, 2025

I tried it out and could confirm that the XHRs happen, and that this patch prevents them.

However, given that:

  • the use case of previewing playbooks is rare
  • even rarer to also have the explorer open while doing so
  • the bug is without any consequences to the user
  • the fix introduces knowledge of study and gamebook to the explorer ctrl which previously had none

I think the fix is worse than the bug. Feel free to argue if you disagree.

@ornicar ornicar closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer remains active in interactive lessons Preview
2 participants