Use the right onError Flutter method for tests

lichess-org · Dec 19, 2024 · aeac25f · aeac25f
1 parent 66216a7
commit aeac25f
Showing 1 changed file with 20 additions and 19 deletions.
diff --git a/test/test_provider_scope.dart b/test/test_provider_scope.dart
@@ -142,8 +142,27 @@ Future<Widget> makeTestProviderScope(
     if (userSession != null) kSessionStorageKey: jsonEncode(userSession.toJson()),
   });
 
+  final flutterTestOnError = FlutterError.onError!;
+
+  void ignoreOverflowErrors(FlutterErrorDetails details) {
+    bool isOverflowError = false;
+    final exception = details.exception;
+
+    if (exception is FlutterError) {
+      isOverflowError = exception.diagnostics.any(
+        (e) => e.value.toString().contains('A RenderFlex overflowed by'),
+      );
+    }
+
+    if (isOverflowError) {
+      // debugPrint('Overflow error detected.');
+    } else {
+      flutterTestOnError(details);
+    }
+  }
+
   // TODO consider loading true fonts as well
-  FlutterError.onError = _ignoreOverflowErrors;
+  FlutterError.onError = ignoreOverflowErrors;
 
   return ProviderScope(
     key: key,
@@ -210,21 +229,3 @@ Future<Widget> makeTestProviderScope(
     child: TestSurface(size: surfaceSize, child: child),
   );
 }
-
-void _ignoreOverflowErrors(FlutterErrorDetails details, {bool forceReport = false}) {
-  bool isOverflowError = false;
-  final exception = details.exception;
-
-  if (exception is FlutterError) {
-    isOverflowError = exception.diagnostics.any(
-      (e) => e.value.toString().contains('A RenderFlex overflowed by'),
-    );
-  }
-
-  if (isOverflowError) {
-    // debugPrint('Overflow error detected.');
-  } else {
-    FlutterError.dumpErrorToConsole(details, forceReport: forceReport);
-    throw exception;
-  }
-}