Release

lidavidm · Jul 13, 2023 · 688f044 · 688f044
1 parent dad4bfb
commit 688f044
Show file tree

Hide file tree

Showing 10 changed files with 26 additions and 6 deletions.
diff --git a/go/adbc/pkg/_tmpl/driver.go.tmpl b/go/adbc/pkg/_tmpl/driver.go.tmpl
@@ -444,6 +444,7 @@ func {{.Prefix}}ConnectionGetInfo(cnxn *C.struct_AdbcConnection, codes *C.uint32
  return C.AdbcStatusCode(errToAdbcErr(err, e))
  }
 
+ defer rdr.Release()
  cdata.ExportRecordReader(rdr, toCdataStream(out))
  return C.ADBC_STATUS_OK
 }
@@ -489,6 +490,7 @@ func {{.Prefix}}ConnectionGetObjects(cnxn *C.struct_AdbcConnection, depth C.int,
  if e != nil {
  return C.AdbcStatusCode(errToAdbcErr(err, e))
  }
+ defer rdr.Release()
  cdata.ExportRecordReader(rdr, toCdataStream(out))
  return C.ADBC_STATUS_OK
 }
@@ -529,6 +531,7 @@ func {{.Prefix}}ConnectionGetTableTypes(cnxn *C.struct_AdbcConnection, out *C.st
  if e != nil {
  return C.AdbcStatusCode(errToAdbcErr(err, e))
  }
+ defer rdr.Release()
  cdata.ExportRecordReader(rdr, toCdataStream(out))
  return C.ADBC_STATUS_OK
 }
@@ -549,6 +552,7 @@ func {{.Prefix}}ConnectionReadPartition(cnxn *C.struct_AdbcConnection, serialize
  if e != nil {
  return C.AdbcStatusCode(errToAdbcErr(err, e))
  }
+ defer rdr.Release()
  cdata.ExportRecordReader(rdr, toCdataStream(out))
  return C.ADBC_STATUS_OK
 }
@@ -716,6 +720,7 @@ func {{.Prefix}}StatementExecuteQuery(stmt *C.struct_AdbcStatement, out *C.struc
  *affected = C.int64_t(n)
  }
 
+ defer rdr.Release()
  cdata.ExportRecordReader(rdr, toCdataStream(out))
  }
  return C.ADBC_STATUS_OK

diff --git a/go/adbc/pkg/flightsql/driver.go b/go/adbc/pkg/flightsql/driver.go
diff --git a/go/adbc/pkg/flightsql/utils.c b/go/adbc/pkg/flightsql/utils.c
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #include "utils.h"
 

diff --git a/go/adbc/pkg/flightsql/utils.h b/go/adbc/pkg/flightsql/utils.h
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #pragma once
 

diff --git a/go/adbc/pkg/panicdummy/driver.go b/go/adbc/pkg/panicdummy/driver.go
diff --git a/go/adbc/pkg/panicdummy/utils.c b/go/adbc/pkg/panicdummy/utils.c
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #include "utils.h"
 

diff --git a/go/adbc/pkg/panicdummy/utils.h b/go/adbc/pkg/panicdummy/utils.h
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #pragma once
 

diff --git a/go/adbc/pkg/snowflake/driver.go b/go/adbc/pkg/snowflake/driver.go
diff --git a/go/adbc/pkg/snowflake/utils.c b/go/adbc/pkg/snowflake/utils.c
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #include "utils.h"
 

diff --git a/go/adbc/pkg/snowflake/utils.h b/go/adbc/pkg/snowflake/utils.h
@@ -19,7 +19,7 @@
 
 // clang-format off
 //go:build driverlib
-//  clang-format on
+// clang-format on
 
 #pragma once