Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: embedded EIP712 for StETH #640

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Feat: embedded EIP712 for StETH #640

merged 1 commit into from
Feb 20, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Feb 20, 2023 •
edited
Loading

Allows providing a signature for the proper StETH token address instead of the EIP-712 helper:

-    domainSeparator = makeDomainSeparator('Liquid staked Ether 2.0', '2', chainId, eip712StETH.address)
+    domainSeparator = makeDomainSeparator('Liquid staked Ether 2.0', '2', chainId, stEth.address)

@TheDZhon
feat: use embedded EIP712 for StETH
aeca08c 
The idea is to provide the signature for the proper StETH token address.
@TheDZhon TheDZhon mentioned this pull request Feb 20, 2023
Merged
26 tasks
@TheDZhon TheDZhon merged commit dd5c631 into feature/shapella-upgrade-followups Feb 20, 2023
@TheDZhon TheDZhon deleted the fix/embedded-eip712 branch February 20, 2023 13:02
@TheDZhon
Copy link
Contributor Author

OpenZeppelin/openzeppelin-contracts#2852

An interesting historical entry regarding checking address(this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arwer13 arwer13 arwer13 approved these changes

@DiRaiks DiRaiks Awaiting requested review from DiRaiks

@folkyatina folkyatina Awaiting requested review from folkyatina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheDZhon @arwer13