rought draft: BRING YOUR OWN DSM (for permissiones staking vaults) [very very WIP] #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkyatina
requested changes
Jan 3, 2025
|
|
||
| bytes32 currentDepositRoot = _depositContract.get_deposit_root(); | ||
| bytes32 securityMessageHash = keccak256(abi.encodePacked(GUARDIAN_SIGNATURE_PREFIX, currentDepositRoot, depositDataRoots)); | ||
| address signer = ECDSA.recover(securityMessageHash, _guardianSignature.r, _guardianSignature.vs); |
There was a problem hiding this comment.
Looks like it's worth to push this implementation a bit further over the abstraction path.
We can support ERC-1271 here and thus the other contract can be a guardian.
We can have an implementation of the "Lido Vaults DSM" as the guardian contract, so we can interchange them.
So, we can have some vaults protected by EOA guardian and some — by DSM committee.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a simple way to validate owner's validation of deposit data (Similary mechanism to DSM but with owner of the vault acting as the sole guardian)