Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: L2s diffyscan #18

Merged
merged 12 commits into from
Oct 10, 2023
Merged

Feat: L2s diffyscan #18

merged 12 commits into from
Oct 10, 2023

Conversation

TheDZhon
Copy link
Contributor

@TheDZhon TheDZhon commented Oct 7, 2023 •
edited
Loading

image

  • Support zkSync Era blockchain explorer
  • Can set repository prefix for the contracts repo
  • Can have a dependency with multiple GH repos
  • Add sample configs for

Closes #15

@TheDZhon
feat: refactor config format
164ba72 
Allow blockscan flavor to be either Etherscan or ZkSync blockscan
Allow repo prefixes
Explicitly set commits
Allow multiple repos for the same dependendency (ugh)
@TheDZhon
config: add samples
a1480f5
kovalgek
kovalgek requested changes Oct 9, 2023
View reviewed changes
utils/explorer.py Outdated Show resolved Hide resolved
utils/github.py Outdated Show resolved Hide resolved
config_samples/zksync_testnet_config_L2.json Outdated Show resolved Hide resolved
folkyatina
folkyatina reviewed Oct 9, 2023
View reviewed changes
utils/github.py Outdated Show resolved Hide resolved
utils/github.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config_samples/zksync_testnet_config_L2.json Outdated Show resolved Hide resolved
arwer13
arwer13 requested changes Oct 9, 2023
View reviewed changes
utils/common.py Outdated Show resolved Hide resolved
config_samples/zksync_testnet_config_L2.json Outdated Show resolved Hide resolved
config_samples/lido_dao_holesky_config.json Show resolved Hide resolved
mymphe
mymphe approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mymphe mymphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arwer13 arwer13 self-requested a review October 10, 2023 08:56
folkyatina
folkyatina reviewed Oct 10, 2023
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good good

README.md Outdated Show resolved Hide resolved
config_samples/zksync_testnet_config_L2.json Show resolved Hide resolved
config_samples/optimism_mainnet_config_L2.json Show resolved Hide resolved
@TheDZhon TheDZhon merged commit a01f841 into main Oct 10, 2023
@TheDZhon TheDZhon deleted the feat/crosschain-diffyscan branch October 10, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkyatina folkyatina folkyatina left review comments

@mymphe mymphe mymphe approved these changes

@kovalgek kovalgek kovalgek approved these changes

@arwer13 arwer13 arwer13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposed Enahancement: Support L2s and other chains
5 participants
@TheDZhon @folkyatina @arwer13 @kovalgek @mymphe