Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add various setup improvements #4

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Fix: add various setup improvements #4

merged 3 commits into from
Apr 26, 2023

Conversation

TheDZhon
Copy link
Contributor

  • Add MIT license
  • Enrich the pyproject.toml contents
  • Use ETHERSCAN_TOKEN instead of ETHERSCAN_API_TOKEN for compatibility with web3 frameworks such as brownie
  • Provide setup instructions and list dependencies
  • Exit early if a single contract requested without its name

mymphe
mymphe reviewed Apr 26, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
folkyatina
folkyatina approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@folkyatina folkyatina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically LGTM

main.py Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit 5bc3b4a into main Apr 26, 2023
@TheDZhon TheDZhon deleted the fix/setup-improvements branch April 26, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mymphe mymphe mymphe approved these changes

@folkyatina folkyatina folkyatina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheDZhon @folkyatina @mymphe