Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop to Main #63

Merged
merged 123 commits into from
Oct 15, 2024
Merged

Develop to Main #63

merged 123 commits into from
Oct 15, 2024

Conversation

TheDZhon
Copy link
Contributor

based on #52 with the following changes:

  • opt-in
  • mask RPC URLs
  • a few chores for error codes

Alexvozhak and others added 30 commits July 7, 2024 16:24
@Alexvozhak
Added binary verificator
4304dfe
@Alexvozhak
Added binary verification through Ganache
aa6733a
@Alexvozhak
Made work with env uniform
4229785
@Alexvozhak
Corrected the alignment in lido_dao_sepolia_config.json
cf4cad1
@Alexvozhak
Updated readme
34c6851
@Alexvozhak
Reverted taking etherscan env var from config
c53391b
@Alexvozhak
Fixed relative paths
f77bf50
@Alexvozhak
Added Ganache checks
43336d8
@Alexvozhak
Formatted the code in Black style
d445eb3
@Alexvozhak
Merge branch 'main' into binary_verificator
c3ad6b2
@Alexvozhak
fixed binary-check arg, removed autoclean arg
3e093de
@Alexvozhak
Moved from Ganache to Hardhat
930c0d8
@Alexvozhak
Renamed Ganache to Hardhat in logs
1b38ff6
@Alexvozhak
Added new arg for Hardhat config path
72faada
@Alexvozhak
Added small check before deleting compilers directory
2c5c831
@Alexvozhak
Now eth_accounts is sent at once
3c40dd8
@Alexvozhak
Fixed review comments
234543c
@Alexvozhak
Refactored binary_verifier.py
5c7dcc9
@Alexvozhak
Trying to fix Hardhat
d33d546
@Alexvozhak
Revert "Trying to fix Hardhat"
c5c136c 
This reverts commit d33d546.
@Alexvozhak
Trying to fix Hardhat autoinstall #2
0719e62
@Alexvozhak
Updated readme
7d47afe
@Alexvozhak
Updated RPC URL for sepolia
300eb77
@Alexvozhak
Moved 'constructor_args' into 'binary_checking' section. Also small f…
ee579a2 
…ixes
@Alexvozhak
Filling holesky config (3/53)
835338a
@Alexvozhak @tamtamchik
Update README.md
5362009 
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
@Alexvozhak @tamtamchik
Update README.md
1210abc 
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
@Alexvozhak @tamtamchik
Update README.md
43d6deb 
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
@Alexvozhak @tamtamchik
Update README.md
c6803c5 
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
@Alexvozhak @tamtamchik
Update diffyscan/utils/explorer.py
138fdd4 
Co-authored-by: Yuri Tkachenko <yuri.tam.tkachenko@gmail.com>
Alexvozhak and others added 19 commits September 13, 2024 01:36
@Alexvozhak
added random guid for temp .sol files
dc318d9
@Alexvozhak
fixed readme by remark
42fcee7
@Alexvozhak
added extra comment for encode_constructor_arguments()
62881b9
@Alexvozhak
renamed raise_exceptions_on_comparison to fail_on_comparison_error
102c72b
@Alexvozhak
uniqueness in readme example has been enforced
ac4419e
@Alexvozhak
fixed diffyscan example call for pipx usage
601ccbe
@Alexvozhak
Added handling different codes length
498be46
@Alexvozhak
Fixed logic for calldata in config
9dc240f
@Alexvozhak
added comment for near_lines_count constant
d71d9f2
@Alexvozhak
Changed hardfork from istanbul to cancun
8493437
@Alexvozhak
Husky integrated with precommit hook
37617f7
@Alexvozhak
tested encoding bytes on optimizm contract
2516736
@Alexvozhak
added automatic reconnection to Hardhat
4c6b2d6
@Alexvozhak
updated package.json and package-lock.json
3d99f67
@Alexvozhak
added trimming metadata, optimized algorithm, fixed sepolia config
82479e3
@Alexvozhak
Merge branch 'main' into binary_verificator
ea3429e
@TheDZhon
Merge pull request #52 from Alexvozhak/binary_verificator
7f6091d 
Add Ethereum Smart Contract binary bytecode matching
@TheDZhon
fix: ignore cache artifacts
f5466ff
@TheDZhon
fix: enhance binary verification, make opt-in
dd5bf94
tamtamchik
tamtamchik approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@tamtamchik tamtamchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No major issues.

Just small suggestions.

.husky/pre-commit Outdated Show resolved Hide resolved
diffyscan/diffyscan.py Outdated Show resolved Hide resolved
hardhat_configs/holesky_hardhat_config.js Outdated Show resolved Hide resolved
diffyscan/utils/hardhat.py Outdated Show resolved Hide resolved
diffyscan/utils/constants.py Outdated Show resolved Hide resolved
@TheDZhon TheDZhon merged commit 7d1a27f into main Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamtamchik tamtamchik tamtamchik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheDZhon @tamtamchik @Alexvozhak