ET factories for stablecoins #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
a46dd3f
to
b575c80
Compare
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
b575c80
to
a3e9ac3
Compare
Psirex
reviewed
Oct 6, 2023
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
1937717
to
f9d7b34
Compare
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
f9d7b34
to
a7eafa7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
e7e8c44
to
dc03baa
Compare
rkolpakov
force-pushed
the
feature/top-up-allowed-tokens
branch
from
dc03baa
to
3b718ad
Compare
Psirex
reviewed
Oct 26, 2023
TheDZhon
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
LGTM 🍏
Left some nitpicks and rough thoughts only.
Given the following:
- additional security measurements implemented with LIP-13 and preserved with this deployment as well
- only the DAO Agent can change the token list
The risks are tolerable and good to go from my side.
| // plus 1 because index 0 means a value is not in the set. | ||
| mapping(address => uint256) private allowedTokenIndices; | ||
|
|
||
| /// @notice Precise number of tokens in the system |
There was a problem hiding this comment.
the comment is misleading a bit (the definition is close to 'total supply')
| return allowedTokens; | ||
| } | ||
|
|
||
| /// @notice Transforms amout from token format to precise format |
| @@ -0,0 +1,130 @@ | |||
| // SPDX-FileCopyrightText: 2022 Lido <info@lido.fi> | |||
There was a problem hiding this comment.
old copyright (not only in this file)
| import "OpenZeppelin/openzeppelin-contracts@4.3.2/contracts/access/AccessControl.sol"; | ||
| import "OpenZeppelin/openzeppelin-contracts@4.3.2/contracts/token/ERC20/extensions/IERC20Metadata.sol"; | ||
|
|
||
| contract AllowedTokensRegistry is AccessControl { |
There was a problem hiding this comment.
why not AccessControlEnumerable?
| return _tokenAmount * 10 ** (DECIMALS - tokenDecimals); | ||
| } | ||
|
|
||
| /// @notice Returns precision of the token |
| event TopUpAllowedRecipientsDeployed( | ||
| address indexed creator, | ||
| address indexed topUpAllowedRecipients, | ||
| address trustedCaller, | ||
| address allowedRecipientsRegistry, | ||
| address allowedTokenssRegistry, |
There was a problem hiding this comment.
there some memory[] external func args left still
| @@ -75,18 +84,38 @@ contract AllowedRecipientsFactory { | |||
| ); | |||
| } | |||
|
|
|||
| function deployAllowedTokensRegistry( | |||
There was a problem hiding this comment.
not a strong point: maybe semantically, it could have been a dedicated factory for the tokens registry (since doesn't affect allowed recipients)
| @@ -37,6 +37,22 @@ def addresses(network=DEFAULT_NETWORK): | |||
| ) | |||
|
|
|||
|
|
|||
| def external_contracts(network=DEFAULT_NETWORK): | |||
| if network == "mainnet" or network == "mainnet-fork": | |||
| return { | |||
…kens upgrade dependencies in feature/top-up-allowed-tokens
…wed-tokens-registry
…-registry added scripts for deployment with an existing tokens registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.