feat: csm el stealing penalty settling #71

vgorkavenko · 2024-05-24T06:44:26Z

EasyTrack factory for CSM EL stealing penalty workflow

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

…hai-hardfork

utils/csm.py

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

chore: shanghai hardfork

* feat: deploy script * feat: acceptance deploy script

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

Co-authored-by: Eugene Mamin <TheDZhon@gmail.com>

bulbozaur · 2024-10-08T07:43:16Z

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

+        return abi.decode(_evmScriptCallData, (uint256[]));
+    }
+
+    function _validateInputData(


There is no check on duplicates, wont it cause any issues? Haven't found this case covered covered by tests in CSM repo.

added here lidofinance/community-staking-module#346

bulbozaur · 2024-10-08T08:10:11Z

tests/scripts/test_grant_executor_permissions.py

@@ -4,8 +4,7 @@
 from utils import lido


-def test_grant_executor_permissions(accounts):
-    lido_contracts = lido.contracts(network=brownie.network.show_active())


unused lido imports in files after switching to fixture

bulbozaur · 2024-10-08T08:12:40Z

network-config.yaml

+      chain_id: 17000
+      evm_version: shanghai
+      fork: $HOLESKY_RPC_URL
+      gas_limit: 12000000000


Whats the reason for extra holesky network with such a huge gas limit?

it was needed for devnet purposes. will remove

bulbozaur · 2024-10-08T08:15:09Z

tests/scripts/test_revoke_all_permissions.py

@@ -5,8 +5,7 @@
 from utils import lido


-def test_revoke_permissions(accounts):
-    lido_contracts = lido.contracts(network=network.show_active())


Also import here

Psirex · 2024-10-08T06:57:53Z

scripts/deploy_csm_settle_el_stealing_factory.py

+    log.nb("All factories have been deployed.")
+    log.nb("Saving atrifacts...")
+
+    with open(f"deployed-{network_name}.json", "w") as outfile:


Seems like this will rewrite the current deployed-{network_name}.json file, consider using different name for the file

Psirex · 2024-10-08T07:30:36Z

network-config.yaml

@@ -13,7 +13,7 @@ development:
  - cmd: ./ganache.sh
    cmd_settings:
      accounts: 10
-      evm_version: istanbul
+      evm_version: shanghai


Do we really need a Shanghai version in tests? The compiler version will still be Istanbul, as contracts are written on the 0.8.6 Solidity version.

yes we need. because contract calls csm contract in _validateInput when createEVMScript

Psirex · 2024-10-08T07:53:23Z

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

+        return abi.decode(_evmScriptCallData, (uint256[]));
+    }
+
+    function _validateInputData(


bulbozaur

LGTM, but there are some addresses missing in the configurations that need to be filled in after the CSM deployment to pass the mainnet-fork tests before merge.

bulbozaur

LGTM

dgusakov · 2024-10-14T06:12:58Z

All commits were moved to #78

github-advanced-security bot found potential problems May 24, 2024

View reviewed changes

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol Fixed Show fixed Hide fixed

feat: factory and tests

5670cc9

vgorkavenko force-pushed the feat/csm-el-stealing-penalty-settling branch from 8bd164e to 5670cc9 Compare May 24, 2024 07:10

vgorkavenko added 2 commits May 24, 2024 11:39

chore: use shanghai hardfork for tests. set balance

09a1140

feat: factory and tests

21ef7fa

vgorkavenko force-pushed the feat/csm-el-stealing-penalty-settling branch from 5670cc9 to 21ef7fa Compare May 28, 2024 08:14

vgorkavenko changed the title ~~WIP: csm el stealing penalty settling~~ feat: csm el stealing penalty settling May 28, 2024

vgorkavenko marked this pull request as ready for review May 28, 2024 08:14

fix: error

054c5cb

vgorkavenko force-pushed the feat/csm-el-stealing-penalty-settling branch from c462162 to 054c5cb Compare May 28, 2024 08:18

Merge branch 'feat/csm-el-stealing-penalty-settling' into chore/shang…

df8b18e

…hai-hardfork

vgorkavenko requested review from madlabman and skhomuti May 28, 2024 08:36

dgusakov reviewed May 29, 2024

View reviewed changes

utils/csm.py Outdated Show resolved Hide resolved

madlabman reviewed May 30, 2024

View reviewed changes

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol Outdated Show resolved Hide resolved

madlabman reviewed May 30, 2024

View reviewed changes

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol Outdated Show resolved Hide resolved

madlabman reviewed May 30, 2024

View reviewed changes

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol Show resolved Hide resolved

fix: review

e8a3280

vgorkavenko requested review from dgusakov and madlabman May 30, 2024 13:13

Merge pull request #72 from lidofinance/chore/shanghai-hardfork

bafd644

chore: shanghai hardfork

madlabman approved these changes Jun 5, 2024

View reviewed changes

fix: remarks

6babbf0

vgorkavenko requested review from bulbozaur, rkolpakov and Psirex June 6, 2024 09:55

vgorkavenko and others added 3 commits June 24, 2024 15:37

feat: deploy script (#73)

c806738

* feat: deploy script * feat: acceptance deploy script

feat: holesky deployment

131c77a

fix: update abi

dc1b276

TheDZhon reviewed Jul 18, 2024

View reviewed changes

contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol Outdated Show resolved Hide resolved

Update contracts/EVMScriptFactories/CSMSettleELStealingPenalty.sol

13f78f1

Co-authored-by: Eugene Mamin <TheDZhon@gmail.com>

vgorkavenko requested a review from TheDZhon August 14, 2024 14:11

bulbozaur reviewed Oct 8, 2024

View reviewed changes

Psirex reviewed Oct 8, 2024

View reviewed changes

vgorkavenko and others added 4 commits October 8, 2024 23:07

Merge branch 'develop' into feat/csm-el-stealing-penalty-settling

694b4c0

fix: file for csm

49d9524

fix: remove devnet

ed7a4bb

fix: unused imports

7ab457b

vgorkavenko force-pushed the feat/csm-el-stealing-penalty-settling branch from 655d02b to 7ab457b Compare October 8, 2024 19:43

vgorkavenko requested review from bulbozaur and Psirex October 8, 2024 19:59

bulbozaur requested changes Oct 9, 2024

View reviewed changes

vgorkavenko added 2 commits October 9, 2024 15:46

fix: prepare module state in tests

4221786

chore: add CSModule address on mainnet for tests

8ebf896

vgorkavenko force-pushed the feat/csm-el-stealing-penalty-settling branch from 23bb90d to 8ebf896 Compare October 11, 2024 07:45

vgorkavenko requested a review from bulbozaur October 11, 2024 08:25

bulbozaur approved these changes Oct 11, 2024

View reviewed changes

chore: add CSMSettleElStealingPenalty mainnet deployment artifact

9039f23

dgusakov closed this Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: csm el stealing penalty settling #71

feat: csm el stealing penalty settling #71

vgorkavenko commented May 24, 2024 •

edited

Loading

bulbozaur Oct 8, 2024 •

edited

Loading

Psirex Oct 8, 2024

vgorkavenko Oct 8, 2024

bulbozaur Oct 8, 2024

vgorkavenko Oct 8, 2024

bulbozaur Oct 8, 2024

vgorkavenko Oct 8, 2024

vgorkavenko Oct 8, 2024

bulbozaur Oct 8, 2024

vgorkavenko Oct 8, 2024

Psirex Oct 8, 2024

vgorkavenko Oct 8, 2024

Psirex Oct 8, 2024

vgorkavenko Oct 8, 2024

Psirex Oct 8, 2024

bulbozaur left a comment

bulbozaur left a comment

dgusakov commented Oct 14, 2024

feat: csm el stealing penalty settling #71

feat: csm el stealing penalty settling #71

Conversation

vgorkavenko commented May 24, 2024 • edited Loading

bulbozaur Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bulbozaur left a comment

Choose a reason for hiding this comment

bulbozaur left a comment

Choose a reason for hiding this comment

dgusakov commented Oct 14, 2024

vgorkavenko commented May 24, 2024 •

edited

Loading

bulbozaur Oct 8, 2024 •

edited

Loading