Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After TB update to 96.0b1 (64-bit) - DKIM verifier header line dissapeared.. Error #279

Closed
xsistema opened this issue Dec 9, 2021 · 3 comments
Closed

After TB update to 96.0b1 (64-bit) - DKIM verifier header line dissapeared.. Error #279

xsistema opened this issue Dec 9, 2021 · 3 comments
Assignees
@lieser
Labels
bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on
Milestone
4.1.0

Comments

@xsistema
Copy link

xsistema commented Dec 9, 2021 •
edited
Loading

After TB update to 96.0b1 (64-bit) - DKIM verifier header line dissapeared.. Error:

Uncaught Error: Could not find the DKIMHeaderField element
    get jar:file:///C:/Users/xxx/AppData/Roaming/Thunderbird/Profiles/default/extensions/dkim_verifier@pl.xpi!/experiments/dkimHeader.js:340
    reset jar:file:///C:/Users/xxx/AppData/Roaming/Thunderbird/Profiles/default/extensions/dkim_verifier@pl.xpi!/experiments/dkimHeader.js:764
    onStartHeaders jar:file:///C:/Users/xxx/AppData/Roaming/Thunderbird/Profiles/default/extensions/dkim_verifier@pl.xpi!/experiments/dkimHeader.js:773
    onStartHeaders chrome://messenger/content/msgHdrView.js:589
    processHeaders chrome://messenger/content/msgHdrView.js:641
dkimHeader.js:340:10
This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”. Inbox
Could not find the DkimHeaderRow element dkimHeader.js:414
DKIM_Verifier.AuthVerifier	DEBUG	 AuthResult result found:  {"version":"3.0","dkim":[{"version":"2.0","result":"SUCCESS","sdid":"ebay.com","auid":"@ebay.com","selector":"dkim1k","warnings":[{"name":"DKIM_SIGERROR_INSECURE_A"}],"keySecure":false}]} authVerifier.mjs.js:325:6
Error: An unexpected error occurred undefined
Could not find the DKIMHeaderField element dkimHeader.js:340
DKIM_Verifier.background	FATAL	 Unexpected error during verifyMessage <unavailable> background.mjs.js:133:7
Could not find the DkimHeaderRow element dkimHeader.js:414
Could not find the DKIMHeaderField element dkimHeader.js:340
Error: An unexpected error occurred 2 undefined
@shardrunner
Copy link

Same for me.
It even seems to make the complete header field with from field, reply button, ... disappear for the message pane.

@lieser lieser self-assigned this Dec 11, 2021
@lieser lieser added bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on labels Dec 11, 2021
@lieser
Copy link
Owner

lieser commented Dec 11, 2021

Thanks you both for reporting the issue. Had a quick look, and unfortunately this is more than a one line fix.
Seems like Thunderbird is in the progress of changing some elements in the email header, which also requires some changes to the elements the addon is adding.

Will try to fix it in the next few days.

@lieser lieser pinned this issue Dec 11, 2021
@lieser lieser added this to the 4.1.0 milestone Dec 11, 2021
lieser added a commit that referenced this issue Dec 19, 2021
@lieser
fixed incompatibility with Thunderbird 96 (#279)
b2d699a
@lieser
Copy link
Owner

lieser commented Dec 19, 2021

I was able to fix the DKIM header line, and also the favicon which had problems too.

The fix will be included in 4.1.0. Unfortunately I don't think that version will still get released this year.
But I attached a build of the current master that you can already use.
dkim_verifier@pl-b2d699a.zip

@lieser lieser closed this as completed Dec 19, 2021
@lieser lieser unpinned this issue Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lieser lieser

Labels
bug Something isn't working compatibility Related to a specific Thunderbird version or another add-on
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
3 participants
@lieser @shardrunner @xsistema