Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version and id parsing #253

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Fix version and id parsing #253

merged 2 commits into from
Apr 18, 2021

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Apr 18, 2021

This pull request contains two commits.

  • The first one is just a refactor of ARHParser.jsm (for better comparability with the 4.0.0 version)
  • The second one contains the fixes for e113420 and c32c8ae

@lieser lieser merged commit 7d4a73f into lieser:2.x Apr 18, 2021
@lieser lieser added the bug Something isn't working label Apr 18, 2021
@lieser lieser added this to the 2.2.1 milestone Apr 18, 2021
@dodmi dodmi deleted the fixVersionAndIdParsing branch April 18, 2021 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieser lieser lieser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dodmi @lieser