Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated German locales #256

Merged
merged 2 commits into from
May 3, 2021
Merged

Updated German locales #256

merged 2 commits into from
May 3, 2021

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Apr 20, 2021

Hi, I've fixed some typos and wordings in the German translation of the 2.x branch.

Copy link
Owner

@lieser lieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections, and sorry for the late reply.

In two places I think the intended meaning changes slightly. Otherwise looks fine (thought I must admit the correct hyphen usage looks a little strange to me. To used to English and incorrect German spelling).

Will try to also port it to the current master before the next release.

chrome/locale/de/options.dtd Outdated Show resolved Hide resolved
chrome/locale/de/signersRuleHelp.dtd Outdated Show resolved Hide resolved
@dodmi dodmi requested a review from lieser May 1, 2021 21:51
@lieser lieser merged commit e19ba54 into lieser:2.x May 3, 2021
@dodmi dodmi deleted the updGermanLang branch May 4, 2021 17:17
lieser added a commit that referenced this pull request Jul 3, 2021
@lieser
Copy link
Owner

lieser commented Jul 3, 2021

I finally also applied the changes to master. Thanks again for the improvements.

@lieser lieser added this to the 2.2.2 milestone Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants