Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding favicon by auid or from address #376

Conversation

dodmi
Copy link
Contributor

@dodmi dodmi commented Jun 24, 2023

I guess, I can start adding favicons from companies, which use external IT service providers for their newsletters by mail address? Or do you see a problem?

@lieser
Copy link
Owner

lieser commented Jun 25, 2023

I guess, I can start adding favicons from companies, which use external IT service providers for their newsletters by mail address?

If you are talking about company a company.test, using newsletter.test to send e-mails with from e.g. foo@company.test and signed only by newsletter.test, then no.

That was not the use case for #107. I deliberately added the test that the from address is in the SDID, which prohibits this.

I still believe such e-mails should be signed by company.test, even if they are not the direct sender, but only on which behalf it is send. If they trust them to send e-mails on their behalf, they should configure DKIM accordingly that they can use a DKIM key published under the company.test domain.
This trust relationship is something I would like to avoid encoding into our internal list of favicons.

I know there are currently a few examples that contradict this a little and show an icon even if it is only signed by a *.onmicrosoft.com or *.gappssmtp.com SDID. But at least they use a separate sup-domain. And they are two very big companies, there it could be argued it is unlikely they will misbehave.
But this are exceptions I'm not really that happy with, and I would like to avoid making more.

@lieser lieser added the enhancement Improvements or new features label Jun 25, 2023
@lieser lieser added this to the 2.3.0 milestone Jun 25, 2023
@lieser lieser merged commit 704d7f9 into lieser:2.x Jun 25, 2023
@dodmi dodmi deleted the backport-features-5-2.x-favicon-for-auid-or-from-2023-06-23 branch June 25, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants