improve typings

plugins/ember.ts

@@ -9,6 +9,8 @@ import hbsResolver from './hbs-resolver';
 import gtsResolver from './gts-resolver';
 import i18nLoader from './i18n-loader';
 import { babelHotReloadPlugin } from './hot-reload';
+import type { ASTv1 } from '@glimmer/syntax';
+
 
 const selfPath = import.meta.url + '/../..';
 
@@ -30,7 +32,7 @@ export function App(mode: string) {
 
   addon.babelPlugins = [
     hbsResolver(isProd),
-    gtsResolver(isProd),
+    gtsResolver(),
     i18nLoader(),
     !isDev
       ? babel({
@@ -94,7 +96,7 @@ export function emberAppConfig(
 }
 
 function addonBabelConfig(
-  plugins = [],
+  plugins: unknown[] = [],
   isProd: boolean,
   enableSourceMaps = false
 ) {
@@ -255,7 +257,7 @@ export function Addon(name: string, mode: string) {
 }
 
 export function defaultBabelConfig(
-  plugins = [],
+  plugins: unknown[] = [],
   isProd: boolean,
   enableSourceMaps = false
 ) {
@@ -317,11 +319,11 @@ function templateCompilationPlugin(isProd: boolean) {
         refBucketTransform,
         isProd
           ? // eslint-disable-next-line @typescript-eslint/no-unused-vars
-            function sampleTransform(env) {
+            function sampleTransform() {
               return {
                 name: 'skip-prod-test-selectors',
                 visitor: {
-                  ElementNode(node) {
+                  ElementNode(node: ASTv1.ElementNode) {
                     node.attributes = node.attributes.filter(
                       (el) => !el.name.startsWith('data-test-')
                     );

plugins/gts-resolver.js → plugins/gts-resolver.ts

@@ -1,22 +1,25 @@
 import { Preprocessor } from 'content-tag';
+import type { Plugin } from 'vite';
 
 const p = new Preprocessor();
 const fileRegex = /\.(gts|gjs)$/;
 
-function tpl(raw, id) {
+function tpl(raw: string, id: string) {
   return p.process(raw, id);
 }
 
-export default function hbsResolver() {
+export default function hbsResolver(): Plugin {
   return {
     name: 'gts-resolver',
     enforce: 'pre',
     transform(src, id) {
-      if (fileRegex.test(id, id)) {
+      if (fileRegex.test(id)) {
         return {
           code: tpl(src, id),
           map: null, // provide source map if available
         };
+      } else {
+        return void 0;
       }
     },
   };

plugins/hbs-resolver.js → plugins/hbs-resolver.ts

@@ -1,13 +1,16 @@
+import type { Plugin } from 'vite';
+
 const fileRegex = /\.(hbs)$/;
 
-function tpl(raw, id, isProd) {
+function tpl(raw: string, id: string, isProd: boolean) {
   const code = raw.split('`').join('\\`');
 
   const moduleName = id.includes('node_modules')
     ? id.split('node_modules/')[1]
     : id.split('src').pop();
 
-  const name = moduleName.split('/components/').pop().split('.')[0];
+  const name =
+    moduleName?.split('/components/').pop()?.split('.')[0] ?? 'unknown';
   // we always want to return a template-only component
   // and corner-cases handled by patched ember-source, and glimmer
 
@@ -26,16 +29,18 @@ function tpl(raw, id, isProd) {
   // `.trim();
 }
 
-export default function hbsResolver(isProd) {
+export default function hbsResolver(isProd: boolean): Plugin {
   return {
     name: 'hbs-resolver',
     enforce: 'pre',
     transform(src, id) {
-      if (fileRegex.test(id, id)) {
+      if (fileRegex.test(id)) {
         return {
           code: tpl(src, id, isProd),
           map: null, // provide source map if available
         };
+      } else {
+        return void 0;
       }
     },
   };

plugins/i18n-loader.js → plugins/i18n-loader.ts

@@ -2,11 +2,12 @@ import YAML from 'yaml';
 import { readdir, access, readFile } from 'fs/promises';
 import { basename, extname, join } from 'path';
 import { constants } from 'fs';
+import type { Plugin } from 'vite';
 
 const translationsFileName = 'ember-intl/translations';
 const translationsDir = 'translations';
 
-export default function i18nLoader() {
+export default function i18nLoader(): Plugin {
   return {
     name: 'i18n-loader',
     enforce: 'pre',