Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encapsulate LS file-system acces logic into FS provider #303

Merged
merged 4 commits into from
Oct 2, 2021
Merged

encapsulate LS file-system acces logic into FS provider #303

merged 4 commits into from
Oct 2, 2021

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Oct 1, 2021 •
edited
Loading

related to: #302

  • implemented fs-provider with async functions: readFile, exists
  • all internal FS logic is now async
  • in addition, removed Module Unification related logic

@lifeart lifeart mentioned this pull request Oct 1, 2021
Closed
2 tasks
@lifeart lifeart force-pushed the fs-provider branch 3 times, most recently from 2c95abf to 18f6127 Compare October 2, 2021 06:48
@codecov
Copy link

codecov bot commented Oct 2, 2021 •
edited
Loading

Codecov Report

Merging #303 (7c44f5f) into component-context-info-origin (80be4d2) will increase coverage by 0.84%.
The diff coverage is 81.23%.

❗ Current head 7c44f5f differs from pull request most recent head 9043f10. Consider uploading reports for the commit 9043f10 to get more accurate results
Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #303      +/-   ##
=================================================================
+ Coverage                          67.98%   68.82%   +0.84%     
=================================================================
  Files                                 41       42       +1     
  Lines                               3464     3474      +10     
  Branches                             737      733       -4     
=================================================================
+ Hits                                2355     2391      +36     
+ Misses                              1106     1080      -26     
  Partials                               3        3
Impacted Files Coverage Δ
.../builtin-addons/core/script-completion-provider.ts 37.61% <0.00%> (ø)
src/template-linter.ts 52.88% <0.00%> (-0.45%) ⬇️
src/utils/definition-helpers.ts 45.37% <53.57%> (+3.44%) ⬆️
...uiltin-addons/core/template-definition-provider.ts 72.54% <59.52%> (-0.11%) ⬇️
.../builtin-addons/core/script-definition-provider.ts 68.14% <69.69%> (+0.99%) ⬆️
src/start-server.ts 85.71% <80.00%> (-14.29%) ⬇️
src/server.ts 64.45% <80.64%> (+0.37%) ⬆️
src/project-roots.ts 88.59% <86.36%> (-1.59%) ⬇️
src/fs-provider.ts 89.65% <89.65%> (ø)
...uiltin-addons/core/template-completion-provider.ts 92.90% <93.18%> (-0.26%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80be4d2...9043f10. Read the comment docs.

@lifeart
feat: fs provider
b41fc7d 
feat: fs provider

use fs provider for main logic

use fs provider for main logic

fix CI

align deps

fix few usages

more async requests

async fs

fix definitions error

async json

make all things async

remove legacy sync fs api

fix possible side-effects

fix test

fix symbol provider

update ordering in snaphsots

async roots

speedup lookup

async initialize logic

update snapshots
@lifeart lifeart merged commit 16f5203 into component-context-info-origin Oct 2, 2021
@lifeart lifeart deleted the fs-provider branch October 2, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli Awaiting requested review from NullVoxPopuli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lifeart