Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic template imports support (<template> tag and gts, gjs files) #350

Merged
merged 31 commits into from
Feb 5, 2022

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 4, 2022

In scope of this PR i'm planning to land list of primitives to work with mixed content (multiple langs in one file)

To do:

  • add integration test with gjs file
  • add integration test with gts file
  • add linting support to gjs file

#349

image

@lifeart lifeart changed the title draft wip: basic template imports support Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #350 (c9cdd7e) into component-context-info-origin (ef13b60) will increase coverage by 0.53%.
The diff coverage is 79.77%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #350      +/-   ##
=================================================================
+ Coverage                          71.10%   71.63%   +0.53%     
=================================================================
  Files                                 49       53       +4     
  Lines                               4101     4400     +299     
  Branches                             801      838      +37     
=================================================================
+ Hits                                2916     3152     +236     
- Misses                              1182     1245      +63     
  Partials                               3        3              
Impacted Files Coverage Δ
src/builtin-addons/core/code-actions/base.ts 20.37% <25.00%> (-0.56%) ⬇️
src/definition-providers/glimmer-script.ts 25.80% <25.80%> (ø)
src/definition-providers/entry.ts 75.86% <50.00%> (-3.31%) ⬇️
...ion-provider/glimmer-script-completion-provider.ts 84.09% <84.09%> (ø)
src/utils/glimmer-script.ts 85.08% <85.08%> (ø)
...ompletion-provider/template-completion-provider.ts 88.57% <91.30%> (-4.70%) ⬇️
src/utils/glimmer-template.ts 94.00% <94.00%> (ø)
.../completion-provider/script-completion-provider.ts 78.72% <100.00%> (+1.97%) ⬆️
src/template-linter.ts 46.66% <100.00%> (+2.91%) ⬆️
src/utils/layout-helpers.ts 92.23% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34798c9...c9cdd7e. Read the comment docs.

@lifeart lifeart changed the title wip: basic template imports support feat: basic template imports support (<template> tag and gts, gjs files) Feb 5, 2022
@lifeart lifeart merged commit 778c9cb into component-context-info-origin Feb 5, 2022
@lifeart lifeart deleted the template-imports-part-1 branch February 5, 2022 16:18
lifeart pushed a commit that referenced this pull request Feb 5, 2022
# [2.8.0](v2.7.0...v2.8.0) (2022-02-05)

### Features

* basic template imports support (<template> tag and gts, gjs files) ([#350](#350)) ([778c9cb](778c9cb))
@lifeart lifeart mentioned this pull request Feb 6, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant