Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: legacy completion and definition modes for template imports #354

Merged
merged 3 commits into from
Feb 6, 2022

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 6, 2022

image

@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #354 (430fc0c) into component-context-info-origin (ca88dbc) will increase coverage by 0.53%.
The diff coverage is 96.15%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           component-context-info-origin     #354      +/-   ##
=================================================================
+ Coverage                          71.62%   72.15%   +0.53%     
=================================================================
  Files                                 53       53              
  Lines                               4412     4417       +5     
  Branches                             868      869       +1     
=================================================================
+ Hits                                3160     3187      +27     
+ Misses                              1249     1227      -22     
  Partials                               3        3              
Impacted Files Coverage Δ
src/definition-providers/glimmer-script.ts 87.87% <93.33%> (+62.07%) ⬆️
...ion-provider/glimmer-script-completion-provider.ts 82.92% <100.00%> (-1.17%) ⬇️
src/server.ts 63.77% <100.00%> (+0.22%) ⬆️
src/utils/glimmer-script.ts 84.97% <100.00%> (+1.90%) ⬆️
src/definition-providers/entry.ts 75.86% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc54cc0...430fc0c. Read the comment docs.

@lifeart lifeart merged commit 21e11bd into component-context-info-origin Feb 6, 2022
@lifeart lifeart deleted the fix-absolte-content-mapping branch February 6, 2022 14:26
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in neovim!

lifeart pushed a commit that referenced this pull request Feb 6, 2022
# [2.11.0](v2.10.1...v2.11.0) (2022-02-06)

### Features

* legacy completion and definition modes for template imports ([#354](#354)) ([21e11bd](21e11bd))
@lifeart
Copy link
Owner Author

lifeart commented Feb 6, 2022

Legacy_completion_and_completions_from_in-file_scope

@lifeart lifeart mentioned this pull request Feb 6, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants