Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experiment [on with removeEventListener] #105

Closed
wants to merge 1 commit into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 18, 2024

image
clearManyItems1End phase estimated regression +42ms [39ms to 45ms] OR +9.64% [8.97% to 10.27%]
clearManyItems2End phase estimated regression +54ms [51ms to 59ms] OR +13.04% [12.28% to 14.12%]

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 169db21
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65d1ad833e897f0008ac4460
😎 Deploy Preview https://deploy-preview-105--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Code Coverage Report

Coverage after merging experiment-with-remove-event-listener into master

76.15%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.5629, 73, 74, 75, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts95.6079, 8, 9, 97, ...
   dom-api.ts95.6512, 21, 22, 23, ...
   dom.ts98.4290843, 851, 852, 922, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts65.1266.6788, 89, 98, 99, ...
   list.ts93.508066, 70, 71, 72, ...
   reactive.ts91.4756, 61, 66, 67, ...
   rehydration-dom-api.ts48.4196, 97, 98, 99, ...
   rehydration.ts135, 144, 34, 37, ...
   runtime.ts95.7411, 12, 13
   shared.ts76.7095, 96, 97, 98, ...
   vm.ts24, 4
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

Copy link

duration phase estimated regression +139ms [21ms to 267ms] OR +1.06% [0.16% to 2.03%]
renderEnd phase no difference [0ms to 0ms]
render1000Items1End phase no difference [-6ms to 7ms]
clearItems1End phase estimated regression +7ms [3ms to 10ms] OR +6.56% [3.29% to 9.5%]
render1000Items2End phase no difference [-8ms to 1ms]
clearItems2End phase estimated regression +8ms [2ms to 13ms] OR +7.87% [2.39% to 12.57%]
render5000Items1End phase no difference [-15ms to 28ms]
clearManyItems1End phase estimated regression +42ms [39ms to 45ms] OR +9.64% [8.97% to 10.27%]
render5000Items2End phase no difference [-19ms to 15ms]
clearManyItems2End phase estimated regression +54ms [51ms to 59ms] OR +13.04% [12.28% to 14.12%]
render1000Items3End phase estimated improvement -17ms [-32ms to -1ms] OR -2.46% [-4.81% to -0.08%]
append1000Items1End phase no difference [-9ms to 22ms]
append1000Items2End phase no difference [-8ms to 17ms]
updateEvery10thItem1End phase no difference [0ms to 1ms]
updateEvery10thItem2End phase no difference [-14ms to 10ms]
selectFirstRow1End phase estimated regression +2ms [0ms to 10ms] OR +1.75% [0.35% to 7.23%]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 1ms]
removeSecondRow1End phase no difference [0ms to 1ms]
swapRows1End phase estimated improvement -2ms [-13ms to 0ms] OR -0.97% [-7.23% to -0.21%]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase estimated regression +27ms [24ms to 29ms] OR +10.97% [9.99% to 12.02%]
paint phase no difference [0ms to 0ms]

[07:58:55] Generating Benchmark Reports [started]
[07:59:00] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart added the experiment Experimental PR's label Feb 18, 2024
@lifeart lifeart closed this Feb 18, 2024
@lifeart lifeart deleted the experiment-with-remove-event-listener branch February 18, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experiment Experimental PR's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant