Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] style binding #120

Merged
merged 2 commits into from
May 4, 2024
Merged

[feature] style binding #120

merged 2 commits into from
May 4, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented May 3, 2024

telegram-cloud-photo-size-2-5308007591747640002-y

Screen.Recording.2024-05-03.at.20.40.08.mov

todo:

  • move logic to compiler
  • rework node arguments

Copy link

netlify bot commented May 3, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit bcd6293
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/663654456f7cd30008524b60
😎 Deploy Preview https://deploy-preview-120--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart force-pushed the feat-style-binding branch from 2ae2c26 to e4cfc3f Compare May 4, 2024 11:52
Copy link

github-actions bot commented May 4, 2024

Code Coverage Report

Coverage after merging feat-style-binding into master

75.99%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts77.556, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.7929, 77, 78, 79, ...
utils
   component.ts95.7978, 8, 9, 96, ...
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts97.6090821, 829, 830, 901, ...
   reactive.ts91.5056, 61, 66, 67, ...
   runtime.ts95.7411, 12, 13
   shared.ts79.1396, 97, 98, 99, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts63.125076, 77, 95, 99, ...
   list.ts93.588070, 74, 75, 76, ...
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts52.3896, 97, 98, 99, ...
   rehydration.ts135, 144, 34, 37, ...

@lifeart lifeart force-pushed the feat-style-binding branch 2 times, most recently from 00b4bf4 to 84ccc40 Compare May 4, 2024 12:27
@lifeart lifeart force-pushed the feat-style-binding branch from 32547d6 to e43a489 Compare May 4, 2024 12:34
Copy link

github-actions bot commented May 4, 2024

duration phase no difference [-105ms to 62ms]
renderEnd phase estimated regression +1ms [0ms to 3ms] OR +3.76% [0.34% to 8.67%]
render1000Items1End phase no difference [-10ms to 5ms]
clearItems1End phase no difference [-1ms to 3ms]
render1000Items2End phase no difference [-1ms to 2ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-17ms to 19ms]
clearManyItems1End phase no difference [-1ms to 1ms]
render5000Items2End phase no difference [-18ms to 23ms]
clearManyItems2End phase no difference [-7ms to 11ms]
render1000Items3End phase no difference [-17ms to 3ms]
append1000Items1End phase no difference [-15ms to 13ms]
append1000Items2End phase no difference [-20ms to 6ms]
updateEvery10thItem1End phase no difference [-14ms to 11ms]
updateEvery10thItem2End phase no difference [-9ms to 0ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [-1ms to 0ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-2ms to 3ms]
paint phase no difference [0ms to 0ms]

[17:43:21] Generating Benchmark Reports [started]
[17:43:27] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit 77a8644 into master May 4, 2024
8 checks passed
@lifeart lifeart deleted the feat-style-binding branch May 4, 2024 16:56
This was referenced May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant