Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper list items cleanup #179

Merged
merged 1 commit into from
Dec 27, 2024
Merged

proper list items cleanup #179

merged 1 commit into from
Dec 27, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Dec 27, 2024

No description provided.

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 92d0212
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/676efb7e0815e200089e90c4
😎 Deploy Preview https://deploy-preview-179--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Code Coverage Report

Coverage after merging fix-list-destructors into master

79.41%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts96.1930, 87, 88, 89, ...
utils
   component.ts96.368, 80, 82, 9, ...
   context.ts21
   dom-api.ts96.8825, 39, 40, 41, ...
   dom.ts98.7693.88935, 947, 961, 962, ...
   reactive.ts92.8897.0649, 63, 68, 69, ...
   runtime.ts93.5518, 21, 22, 23, ...
   shared.ts73, 89, 95, 98, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts73.5376.9276, 96, 97, 98, ...
   list.ts95.3185.7191, 97, 98, 99, ...
utils/helpers
   and.ts77.784, 5, 6
   eq.ts3, 4
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts71.433, 4, 5
   or.ts4
utils/inspector
   ember-inspector.ts14.70096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts52.3896, 97, 98, 99, ...
   rehydration.ts148, 34, 37, 74, ...

Copy link

duration phase no difference [-45ms to 164ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase no difference [-4ms to 12ms]
clearItems1End phase no difference [0ms to 4ms]
render1000Items2End phase no difference [-2ms to 3ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated regression +24ms [2ms to 44ms] OR +0.71% [0.06% to 1.34%]
clearManyItems1End phase no difference [-6ms to 1ms]
render5000Items2End phase no difference [-16ms to 24ms]
clearManyItems2End phase no difference [-2ms to 3ms]
render1000Items3End phase no difference [-11ms to 3ms]
append1000Items1End phase no difference [-16ms to 17ms]
append1000Items2End phase no difference [-17ms to 16ms]
updateEvery10thItem1End phase no difference [-16ms to 1ms]
updateEvery10thItem2End phase no difference [0ms to 16ms]
selectFirstRow1End phase no difference [0ms to 2ms]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [-16ms to 0ms]
swapRows1End phase no difference [-2ms to 0ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-3ms to 2ms]
paint phase no difference [0ms to 0ms]

[19:56:10] Generating Benchmark Reports [started]
[19:56:18] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit 6a2f217 into master Dec 27, 2024
8 checks passed
@lifeart lifeart deleted the fix-list-destructors branch December 27, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant