Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] trying to run ember-eui #25

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[WIP] trying to run ember-eui #25

wants to merge 4 commits into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 12, 2024

Here I'm exploring drop-in ember addons compatibility

Main deps kinda mocked, we have to create Component -> GlimmerComponent bridge and figure out how to use our plugin to compile templates, vite did not run it over node_modules. Likely need to create custom resolver.. ?

Updates: able to render icon:

1

image

2

image

3

image

4

image

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for g-next failed.

Name Link
🔨 Latest commit bdd4ddf
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65c61907d4e1740008e4e589

@lifeart lifeart mentioned this pull request Jan 13, 2024
14 tasks
@lifeart lifeart force-pushed the ember-eui branch 2 times, most recently from 8a0b139 to 3890d0b Compare January 15, 2024 11:17
@lifeart lifeart force-pushed the ember-eui branch 8 times, most recently from c3f6d16 to 95acffc Compare January 21, 2024 12:05
@lifeart lifeart force-pushed the ember-eui branch 8 times, most recently from 6983a78 to 186048b Compare January 29, 2024 12:09
@lifeart
Copy link
Owner Author

lifeart commented Jan 29, 2024

image need to wrap to `maybeHelper` mustache helpers usage
  • Completed

@lifeart lifeart force-pushed the ember-eui branch 2 times, most recently from 2f2a589 to ff28b6b Compare January 30, 2024 18:00
@lifeart
Copy link
Owner Author

lifeart commented Jan 30, 2024

<div class={{maybeClass  (if @arrowProps.className @arrowProps.className)}}></div>
  • Completed

@lifeart lifeart force-pushed the ember-eui branch 2 times, most recently from 8dbf508 to 9a7aa26 Compare January 30, 2024 18:33
@lifeart lifeart force-pushed the ember-eui branch 7 times, most recently from e51ceef to 9255e1f Compare January 31, 2024 19:38
Copy link

github-actions bot commented Jan 31, 2024

Code Coverage Report

Coverage after merging ember-eui into master

79.42%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts79.596, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.1283.3317, 26
tests
   utils.ts95.6030, 74, 75, 76, ...
utils
   benchmark.ts12
   compat.ts23, 29, 39
   component.ts87, 88, 9, 93, ...
   dom-api.ts13, 22, 47
   dom.ts99.6290.48941, 961, 964, 987, ...
   ember-inspector.ts14.87096, 97, 98, 99, ...
   if.ts65.3866.6788, 89, 90, 99, ...
   list.ts99.3880306, 307, 61, 67, ...
   reactive.ts99.3157, 62, 67, 68, ...
   rehydration-dom-api.ts48.6296, 97, 98, 99, ...
   rehydration.ts136, 145, 35, 38, ...
   runtime.ts12, 19
   shared.ts83, 89, 92, 95, ...
   vm.ts25, 5, 57
utils/helpers
   hash.ts82.6166.6715, 16, 17, 18, ...
   if.ts71.433, 4, 5
utils/inspector
   index.ts33.90096, 97, 98, 99, ...

@lifeart lifeart force-pushed the ember-eui branch 2 times, most recently from 2a0fd93 to fdfc8ac Compare February 2, 2024 09:39
@lifeart lifeart force-pushed the ember-eui branch 2 times, most recently from 0e4cb71 to 946b2c1 Compare February 2, 2024 10:33
@lifeart
Copy link
Owner Author

lifeart commented Feb 2, 2024

todo: figure out why tab buttons not clickable
https://github.com/prysmex/ember-eui/blob/master/packages/core/src/components/eui-tab.gts
May be related to ...attributes handing
image

@lifeart
Copy link
Owner Author

lifeart commented Feb 3, 2024

@lifeart lifeart force-pushed the ember-eui branch 5 times, most recently from 9e85389 to 16a2e83 Compare February 6, 2024 15:17
explore - sub expressions in on modifier
word boundary replacement
fix compiler, add helper/modifier/component helpers
better modifiers
EuiAccordion, EuiPanel
pretty plugin

+

+

carrying args exploration

+

+

+

+

playing with ember component

reactivity inside let argument

+

+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant