Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR & Rehydration #26

Merged
merged 9 commits into from
Jan 15, 2024
Merged

SSR & Rehydration #26

merged 9 commits into from
Jan 15, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 13, 2024

todo:

image

Copy link

netlify bot commented Jan 13, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit c4870bd
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65a4f46ad3b3d90008bb9edc
😎 Deploy Preview https://deploy-preview-26--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart changed the title rechydration-experiments rehydration Jan 13, 2024
Copy link

github-actions bot commented Jan 13, 2024

Code Coverage Report

Coverage after merging rehydration-experiments into master

85.04%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
tests
   utils.ts93.4831, 75, 76, 77, ...
utils
   component.ts89.86226, 228, 291, 292, ...
   destroyable.ts68.756, 7, 8, 9, ...
   dom.ts92.1396.30538, 544, 545, 546, ...
   if.ts59.4866.6796, 97, 98, 99, ...
   list.ts92.7282.3573, 77, 78, 79, ...
   reactive.ts91.9894.7479, 80, 97, 98, ...
   rehydration-dom-api.ts49.2196, 97, 98, 99, ...
   rehydration.ts88.0838, 39, 40, 41, ...
   runtime.ts89.3618, 19, 20, 21, ...
   shared.ts66.9796, 97, 98, 99, ...
utils/helpers
   if.ts66.672, 3, 4

@lifeart lifeart mentioned this pull request Jan 13, 2024
80 tasks
Copy link

github-actions bot commented Jan 13, 2024

duration phase no difference [-72ms to 60ms]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase no difference [-5ms to 8ms]
clearItems1End phase no difference [0ms to 5ms]
render1000Items2End phase no difference [-1ms to 1ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-9ms to 23ms]
clearManyItems1End phase no difference [-1ms to 9ms]
render5000Items2End phase no difference [-8ms to 22ms]
clearManyItems2End phase no difference [-1ms to 6ms]
render1000Items3End phase estimated improvement -2ms [-16ms to 0ms] OR -0.22% [-2.34% to -0.03%]
append1000Items1End phase no difference [-17ms to 1ms]
append1000Items2End phase no difference [-17ms to 1ms]
updateEvery10thItem1End phase no difference [0ms to 1ms]
updateEvery10thItem2End phase no difference [-6ms to 2ms]
selectFirstRow1End phase no difference [0ms to 2ms]
selectSecondRow1End phase no difference [0ms to 1ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [-1ms to 0ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase no difference [-3ms to 1ms]
paint phase no difference [0ms to 0ms]

[10:58:50] Generating Benchmark Reports [started]
[10:58:55] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart changed the title rehydration SSR & Rehydration Jan 14, 2024
@lifeart lifeart marked this pull request as ready for review January 14, 2024 20:30
rechydration-experiments

improve rehydration

fix more rehydration cases

test for if rehydration

list rehydration

reactive lists rehydration

+

+

sample server

recover after failing rehydration

proper destroy for failing app

+

+

one more rehydration test

nested components ref

+

+

+

+

+

+

+

fix linting errors

+

+

+

+

+

more debug names

improve rehydration

+

todo - debug destroy issue

+

woo

improve tests

+

+

+

fix builds

improve testing setup

+

treeshakable api

+

+
@lifeart lifeart force-pushed the rehydration-experiments branch from d51995a to 48d1381 Compare January 14, 2024 21:53
@lifeart lifeart merged commit 08aed4e into master Jan 15, 2024
8 checks passed
@lifeart lifeart deleted the rehydration-experiments branch January 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant