Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-in-element-logic #39

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix-in-element-logic #39

merged 1 commit into from
Jan 17, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 17, 2024

1

image

2

image

3

image

4

image

5

image

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 61b069d
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65a804251d9b7b0008acf0af
😎 Deploy Preview https://deploy-preview-39--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 17, 2024

Code Coverage Report

Coverage after merging fix-in-element into master

86.85%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
tests
   utils.ts95.6531, 75, 76, 77, ...
utils
   component.ts90.2693, 94, 98, 99, ...
   dom.ts96.4596.88504, 577, 578, 579, ...
   if.ts57.2766.6796, 97, 98, 99, ...
   list.ts92.7982.3576, 80, 81, 82, ...
   reactive.ts92.78219, 220, 79, 80, ...
   rehydration-dom-api.ts51.5996, 97, 98, 99, ...
   rehydration.ts92.05147, 148, 149, 150, ...
   runtime.ts89.3618, 19, 20, 21, ...
   shared.ts7492, 93, 94, 95, ...
   vm.ts83.756, 7, 8, 9, ...
utils/helpers
   if.ts66.672, 3, 4

@lifeart lifeart mentioned this pull request Jan 17, 2024
81 tasks
Copy link

github-actions bot commented Jan 17, 2024

duration phase no difference [-165ms to 52ms]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase no difference [-16ms to 2ms]
clearItems1End phase no difference [-2ms to 3ms]
render1000Items2End phase no difference [-14ms to 0ms]
clearItems2End phase no difference [-2ms to 2ms]
render5000Items1End phase no difference [-50ms to 0ms]
clearManyItems1End phase no difference [-5ms to 1ms]
render5000Items2End phase estimated improvement -42ms [-70ms to -15ms] OR -1.17% [-1.94% to -0.43%]
clearManyItems2End phase no difference [-5ms to 4ms]
render1000Items3End phase no difference [-1ms to 16ms]
append1000Items1End phase estimated improvement -17ms [-34ms to 0ms] OR -2.07% [-4.13% to -0.03%]
append1000Items2End phase no difference [-17ms to 15ms]
updateEvery10thItem1End phase no difference [0ms to 15ms]
updateEvery10thItem2End phase estimated improvement -12ms [-17ms to -4ms] OR -2.57% [-3.56% to -0.96%]
selectFirstRow1End phase estimated regression +15ms [11ms to 16ms] OR +11.44% [7.95% to 12.32%]
selectSecondRow1End phase no difference [0ms to 1ms]
removeFirstRow1End phase estimated improvement -1ms [-16ms to 0ms] OR -0.34% [-7.78% to -0.01%]
removeSecondRow1End phase no difference [-1ms to 0ms]
swapRows1End phase no difference [-1ms to 1ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase estimated improvement -3ms [-5ms to 0ms] OR -1.23% [-2.42% to -0.03%]
paint phase no difference [0ms to 0ms]

[18:38:43] Generating Benchmark Reports [started]
[18:38:49] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit d000adc into master Jan 17, 2024
8 checks passed
@lifeart lifeart deleted the fix-in-element branch January 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant