Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime bundle flags configuration #44

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 19, 2024

No description provided.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 5d59e95
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65aa9ac8780c16000807abd9
😎 Deploy Preview https://deploy-preview-44--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lifeart lifeart mentioned this pull request Jan 19, 2024
80 tasks
Copy link

Code Coverage Report

Coverage after merging runtime-bundle-flags-configuration into master

73.76%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts77.556, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.6531, 75, 76, 77, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts96.6570, 8, 9, 91, ...
   dom-api.ts15, 21
   dom.ts96.8491.18592, 595, 614, 75, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts57.2766.6796, 97, 98, 99, ...
   list.ts93.1182.3576, 80, 81, 82, ...
   reactive.ts93.5447, 55, 79, 80, ...
   rehydration-dom-api.ts50.7996, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts95.7411, 12, 13
   shared.ts7492, 93, 94, 95, ...
   vm.ts24, 4
utils/helpers
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

Copy link

github-actions bot commented Jan 19, 2024

duration phase estimated regression +69ms [20ms to 117ms] OR +0.5% [0.14% to 0.84%]
renderEnd phase estimated regression +1ms [0ms to 1ms] OR +2.45% [0.33% to 5.01%]
render1000Items1End phase estimated regression +8ms [2ms to 13ms] OR +0.92% [0.29% to 1.55%]
clearItems1End phase no difference [-1ms to 3ms]
render1000Items2End phase no difference [-3ms to 7ms]
clearItems2End phase no difference [-1ms to 1ms]
render5000Items1End phase estimated regression +17ms [3ms to 33ms] OR +0.48% [0.08% to 0.93%]
clearManyItems1End phase no difference [0ms to 2ms]
render5000Items2End phase estimated regression +23ms [5ms to 40ms] OR +0.65% [0.15% to 1.13%]
clearManyItems2End phase no difference [-1ms to 5ms]
render1000Items3End phase estimated regression +1ms [0ms to 16ms] OR +0.18% [0.01% to 2.29%]
append1000Items1End phase estimated regression +23ms [16ms to 37ms] OR +3.09% [2.14% to 4.89%]
append1000Items2End phase no difference [-16ms to 14ms]
updateEvery10thItem1End phase no difference [-1ms to 0ms]
updateEvery10thItem2End phase estimated improvement -1ms [-13ms to 0ms] OR -0.18% [-2.88% to 0%]
selectFirstRow1End phase no difference [-1ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-2ms to 2ms]
paint phase no difference [0ms to 0ms]

[17:44:50] Generating Benchmark Reports [started]
[17:44:55] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit d79227e into master Jan 19, 2024
8 checks passed
@lifeart lifeart deleted the runtime-bundle-flags-configuration branch January 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant