Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] improve debug info for reactive primitives #56

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 24, 2024

image image

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 02f5b5b
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65b0d4b441e99c0008051fa9
😎 Deploy Preview https://deploy-preview-56--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Code Coverage Report

Coverage after merging feature-improve-debug-info into master

75.18%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts77.556, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.6531, 75, 76, 77, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts98.1673, 8, 9, 94, ...
   dom-api.ts12, 15, 21
   dom.ts99.2892.11655, 662, 681, 75, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts57.2766.6796, 97, 98, 99, ...
   list.ts93.778576, 80, 81, 82, ...
   reactive.ts93.6866, 67, 85, 86, ...
   rehydration-dom-api.ts53.5796, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts95.7411, 12, 13
   shared.ts75.7096, 97, 98, 99, ...
   vm.ts24, 4, 56
utils/helpers
   hash.ts9066.6714, 15
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

@lifeart lifeart mentioned this pull request Jan 24, 2024
80 tasks
Copy link

github-actions bot commented Jan 24, 2024

duration phase no difference [-206ms to 30ms]
renderEnd phase no difference [-2ms to 1ms]
render1000Items1End phase no difference [-16ms to 3ms]
clearItems1End phase no difference [-2ms to 3ms]
render1000Items2End phase no difference [-17ms to 0ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated improvement -32ms [-53ms to -7ms] OR -0.88% [-1.44% to -0.2%]
clearManyItems1End phase no difference [-1ms to 2ms]
render5000Items2End phase no difference [-46ms to 10ms]
clearManyItems2End phase no difference [-4ms to 5ms]
render1000Items3End phase no difference [-16ms to 5ms]
append1000Items1End phase no difference [-25ms to 19ms]
append1000Items2End phase no difference [-39ms to 16ms]
updateEvery10thItem1End phase no difference [-5ms to 15ms]
updateEvery10thItem2End phase no difference [-16ms to 0ms]
selectFirstRow1End phase no difference [-1ms to 0ms]
selectSecondRow1End phase no difference [-1ms to 0ms]
removeFirstRow1End phase no difference [-9ms to 0ms]
removeSecondRow1End phase estimated improvement -1ms [-14ms to 0ms] OR -0.37% [-7.86% to -0.02%]
swapRows1End phase no difference [-1ms to 0ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-1ms to 3ms]
paint phase no difference [0ms to 0ms]

[11:13:53] Generating Benchmark Reports [started]
[11:13:58] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit 024527b into master Jan 24, 2024
8 checks passed
@lifeart lifeart deleted the feature-improve-debug-info branch January 24, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant