Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace glimmer icon #33

Merged
merged 5 commits into from
Jul 15, 2023
Merged

Replace glimmer icon #33

merged 5 commits into from
Jul 15, 2023

Conversation

kaermorchen
Copy link
Contributor

The icon is too heavy right now. I have reversed the color and removed the circle.

It will look something like that:

1
2

@lifeart
Copy link
Owner

lifeart commented Jul 15, 2023

Hi @kaermorchen! Thank for observation! I agree with concerns. Could we somehow adjust centering?
At the moment it looks unbalanced and left-floated -
image

@lifeart
Copy link
Owner

lifeart commented Jul 15, 2023

In addition we could have .gts icon in blue color (to match ts) https://github.com/lifeart/glimmerx-workshop/blob/master/favicon.svg, one more possible icon ref emberjs/ember.js#13949

@kaermorchen
Copy link
Contributor Author

TS icon is added.

1

@kaermorchen
Copy link
Contributor Author

At the moment it looks unbalanced and left-floated -

I have no idea why it unbalanced. The icons have the same size (32px) like another icons from seti-ui theme.

@kaermorchen
Copy link
Contributor Author

Oh, Seti UI uses font icons, not svg

@lifeart
Copy link
Owner

lifeart commented Jul 15, 2023

@kaermorchen I able to center it using viewBox="-3 0 32 32" (changes pushed)

@kaermorchen
Copy link
Contributor Author

@kaermorchen I able to center it using viewBox="-3 0 32 32" (changes pushed)

Will it be centered in another icon theme, like vscode-icons?

@lifeart
Copy link
Owner

lifeart commented Jul 15, 2023

it seems nope:
image

@kaermorchen
Copy link
Contributor Author

🤦 fucking icons...

@kaermorchen
Copy link
Contributor Author

Lets it be as it is

@lifeart
Copy link
Owner

lifeart commented Jul 15, 2023

@kaermorchen how about this case?
image
(going to push it with -bold prefix)

@lifeart lifeart merged commit 44b722d into lifeart:master Jul 15, 2023
@evoactivity
Copy link
Contributor

My desginer brain needs to fix those icons properly. Shouldn't need to use negative values in the viewbox, the icon is right aligned, it just needs nudging to the left. I can create proper cut outs for the JS/TS tags too.

@kaermorchen
Copy link
Contributor Author

Another variants

icons

@kaermorchen
Copy link
Contributor Author

mustache-ts
mustache-js
g-ts
g-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants