-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: makes AWSbatch the default executor #161
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielboloc
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great new feature @dapineyro! And is great that it still maintains backwards compatibility so we don't have to change all our CI tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes AWS batch the default executor, so there is no need to specify
--batch
for thecloudos job run
command.Jira ticket
DEL-17662 & LP-6350
Changes
--ignite
flag to allow ignite executor if available. Using it shows a warning message to alert the user the command may fail.--batch
flag unnecessary, although using it will not break the command, to maintain backwards compatibility.--job-queue
.v2.7.0
.--batch
flag.--help
messages.Tests
Setting up variables:
Running docker image:
CloudOS job using the old
--batch
flagCloudOS job not using any flag (new default)
CloudOS job using an existing queue
CloudOS job using a non-existing queue
CloudOS job trying to use
--ignite
in a non-ignite workspace