-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: release 2.8.0 - adds hpc support #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielboloc
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice addition!
I just added some tiny format suggestions
Thanks for the suggestions @danielboloc ! I've accepted all of them 👍 |
danielboloc
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds preliminary support for HPC execution platform in CloudOS. It will allow to submit HPC jobs in workspaces in which it's prepared to.
Jira ticket
LP-9412
LIF-166
Changes
--execution-platform
parameter, now acceptinghpc
.--hpc-id
to provide the ID. Note that the default value included is only added for internal testing purposes.--execution-platform hpc
is used, a new message is displayed in stdout to tell the user some parameters of cloudos-cli are not valid and will be ignored.v2.8.0
.Tests (on DEV)
Running docker image:
Setting up variables:
CloudOS-CLI job using the new HPC execution platform
CloudOS-CLI job using the new HPC execution platform, but using useless parameters
CloudOS-CLI job using default AWSbatch