Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite existing env vars #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't overwrite existing env vars #49

wants to merge 3 commits into from

Conversation

bbelyeu
Copy link
Contributor

@bbelyeu bbelyeu commented Jul 15, 2020

when pulling in Gitlab secrets

Don't overwrite existing env vars
47f1a23 
when pulling in Gitlab secrets
@bbelyeu
Copy link
Contributor Author

bbelyeu commented Jul 15, 2020

@chrisvaughn and @justin-richert

@chrisvaughn
Copy link
Member

I think there a couple of other places that would need this check. get_secrets_for_creation specifically but I see other places that are getting SECRET_ env vars and processing them.

@bbelyeu
Copy link
Contributor Author

bbelyeu commented Jul 15, 2020

yeah, I'm not sure if the last one is actually needed or not...

@bbelyeu
Copy link
Contributor Author

bbelyeu commented Jul 15, 2020

but I've done the same hack in all the SECRET_ parsing locations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin-richert justin-richert justin-richert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbelyeu @chrisvaughn @justin-richert