LPS-197124 - Cookies PreAction setup #3892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All this cookies NECESSARY, FUNCTIONAL, PERFORMANCE & PERSONALIZATION belongs to the necessary cookies group. Handle its value depending on the user Cookie preference configuration
Only remove the cookie that remembers if users had configured cookies configuration modal
|
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-197124 1 Failed Jobs:For more details click here. [java] java.lang.Exception: Found 8 formatting issues:
[java] 1: > 80: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 219 (SourceCheck:JavaLongLinesCheck)
[java] 2: > 80: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 248 (SourceCheck:JavaLongLinesCheck)
[java] 3: > 80: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 253 (SourceCheck:JavaLongLinesCheck)
[java] 4: > 80: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 268 (SourceCheck:JavaLongLinesCheck)
[java] 5: > 80: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 269 (SourceCheck:JavaLongLinesCheck)
[java] 6: Variable 'hasConsentTypeFunctionalCookie' is unused: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 568 (Checkstyle:UnusedVariableCheck)
[java] 7: Variable 'hasConsentTypePerformanceCookie' is unused: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 572 (Checkstyle:UnusedVariableCheck)
[java] 8: Variable 'hasConsentTypePersonalizationCookie' is unused: ./modules/apps/cookies/cookies-impl/src/main/java/com/liferay/cookies/internal/manager/CookiesManagerImpl.java 576 (Checkstyle:UnusedVariableCheck)
[java]
[java] at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:458)
[java] at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:291)
[stopwatch] [run.batch.test.action: 1:47.394 sec]
[echo] The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:504: The following error occurred while executing this line:
[echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:648: Java returned: 1
[get] Getting: http://test-1-1/job/test-portal-source-format/3543//consoleText
[get] To: /opt/dev/projects/github/liferay-portal/20231212074507797.txt
[delete] Deleting: /opt/dev/projects/github/liferay-portal/20231212074507797.txt
[typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found. |
|
Jenkins Build:test-portal-source-format#3543 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3892 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - juanjofgliferay > liferay-frontend - PR#3892 - 2023-12-12[07:41:25] Testray Importer:publish-testray-report#23596 |
|
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-197124 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#6084 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#3892 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - juanjofgliferay > liferay-frontend - PR#3892 - 2023-12-18[23:31:08] Testray Importer:publish-testray-report#23340 |
|
put on hold till we resolve conversation with app-sec team |
@dsanz @juanjofgliferay Is this something we are strill waiting on? Or we have just forgot about it? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hold: #3892 (comment)
Issue
Liferay allows users to configure how they want to handle their cookies preferences, letting the platform to store information based on 4 different cookie groups: Necessary, Functional, Performance and Personalization cookies. However, Liferay uses cookies to store the cookie information 🤷 . Actually, those cookies, considered Necessary, are not created until the users confirm their preferences.
We need to setup those basic cookies no matter when a user confirms (or not) cookie preferences. To setup the basic cookies we need to consider some scenarios:
1 - First access
Setup basic cookies configuration.
2 - Based on Cookies Preference handling options
2a - Both options enabled
Setup basic cookies configuration (1) or load stored cookie preferences
2b - Preference handling enabled / Explicit consent mode disabled
Setup basic cookies configuration (1) or load stored cookie preferences
2c - Preference handling disabled / Explicit consent mode enabled
Setup basic cookies configuration (1), remove stored cookie preferences if any
2d - Both options disabled
Setup basic cookies configuration (1) or load stored cookie preferences