LPD-36095 Add dependencies to properly format workspaces #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-36095 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#10128 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4413 Testray Routine:EE Pull Request Testray Build ID:8062201 Testray Importer:publish-testray-report#38730 |
✔️ ci:test:stable - 28 out of 28 jobs passed✔️ ci:test:relevant - 31 out of 31 jobs passed in 2 hours 1 minuteClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 2ab0639159f0f653153be46d54c35665a1f5a1e1 ci:test:stable - 28 out of 28 jobs PASSED28 Successful Jobs:
ci:test:relevant - 31 out of 31 jobs PASSED31 Successful Jobs:
For more details click here.Test bundle downloads:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#17899 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4413 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - kevenleone > liferay-frontend - PR#4413 - 2024-09-11[07:51:28] Testray Build ID:8236352 Testray Importer:publish-testray-report#38736 |
bryceosterhaus
requested changes
Sep 18, 2024
| "@typescript-eslint/eslint-plugin": "8.5.0", | ||
| "babel-eslint": "^10.0.3", | ||
| "eslint": "8.56.0", | ||
| "execa": "^9.2.0", |
There was a problem hiding this comment.
This shouldn't be a dependency, it has nothing to do with the others.
| "eslint": "8.56.0", | ||
| "execa": "^9.2.0", | ||
| "prettier": "3.3.3", | ||
| "stylelint": "16.9.0", |
There was a problem hiding this comment.
Is this necessary? It is separate from eslint and prettier
|
@kevenleone I'm closing this due to inactivity. If you still need this merged, please resend and we'll take another look. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://liferay.atlassian.net/browse/LPD-36095
This ticket is a follow up of brianchandotcom#153397
I added few more libraries to the package.json to properly format the files