forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-41485 - Activate/Deactivate Data Set sub entities #4622
Draft
juanjofgliferay
wants to merge
11
commits into
liferay-frontend:master
Choose a base branch
from
juanjofgliferay:LPD-41485
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
LPD-41485 - Activate/Deactivate Data Set sub entities #4622
juanjofgliferay
wants to merge
11
commits into
liferay-frontend:master
from
juanjofgliferay:LPD-41485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - failure
and removed
ci:test:sf - pending
labels
Dec 18, 2024
❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-41485 1 Failed Jobs:For more details click here.[exec] > Task :packageRunCheckFormat [exec] yarn run v1.13.0 [exec] \$ node-scripts check:ci [exec] [exec] ?????? Running preflight checks... [exec] [exec] ?????? Checking outdated tsconfig.json files ... [exec] [exec] ?????? Running TypeScript checks on modified files... [exec] ?????? A total of 8 CPUs were detected: launching tsc using 8 workers [exec] ??? Checked apps/frontend-data-set/frontend-data-set-admin-web [exec] [exec] ?????? Running format checks on modified files... [exec] /opt/dev/projects/github/liferay-portal/modules/test/playwright/tests/frontend-data-set-admin-web/tests/data-set-admin/clientExtensionFilters.spec.ts [exec] 6:9 error 'Locator' is defined but never used. Allowed unused vars must match /^_/u. @typescript-eslint/no-unused-vars [exec] [exec] ??? 1 problem (1 error, 0 warnings) [exec] [exec] [exec] ??? CI checks failed. [exec] error Command failed with exit code 1. [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. [exec] [exec] > Task :packageRunCheckFormat FAILED [exec] Gradle build finished at 2024-12-18 07:59:30.518. [exec] [exec] [exec] FAILURE: Build failed with an exception. [exec] [exec] * What went wrong: [exec] Execution failed for task ':packageRunCheckFormat'. [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1 [exec] [exec] * Try: [exec] > Run with --info or --debug option to get more log output. [exec] > Run with --scan to get full insights. [exec] > Get more help at https://help.gradle.org. [exec] [exec] 3 actionable tasks: 3 executed* Exception is: [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'. [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:148) [exec] [exec] [exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282) [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2024-12-17-23-58-58.html at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146) |
Jenkins Build:test-portal-source-format#7450 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4622 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - juanjofgliferay > liferay-frontend - PR#4622 - 2024-12-17[23:54:46] Testray Build ID:94719116 Testray Importer:publish-testray-report#5401 |
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-41485 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#6046 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4622 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - juanjofgliferay > liferay-frontend - PR#4622 - 2024-12-18[00:03:00] Testray Build ID:94724355 Testray Importer:publish-testray-report#6810 |
It is used with 'sm' size everywhere. No need to customize yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story / Task
LPD-39965 / LPD-41485
Dependencies
inactive
flag (or whatever)Goal
Provide a mechanism to activate or deactivate Data Set sub entities. Focused on Actions, Filters and Sorts. The flag has been added to all visualization mode sections, just in case.
UI