Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPD-47691 Implement new interface to get a REST API element by id, implement it by REST Builder and use it from Search #2523

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

LPD-47691 Implement new interface to get a REST API element by id, implement it by REST Builder and use it from Search #2523

wants to merge 41 commits into from
+5,316 −772

Conversation

ccorreagg
Copy link
Collaborator

@ccorreagg ccorreagg commented Feb 6, 2025 •
edited
Loading

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:sf

@ccorreagg
Copy link
Collaborator Author

ci:test:relevant

@ccorreagg
Copy link
Collaborator Author

ci:test:headless

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 20cac63d619b4803be9c429f00a285540558efeb

Sender Branch:

Branch Name: LPD-47691-2
Branch GIT ID: a9dc3f0386f4f2e268e3234bbd26360c2c724857

0 out of 1jobs PASSED
For more details click here.
format-source-files:
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/portal-search/portal-search-rest-impl/build.gradle expected:<...ore", version: "3.5.[10"
     [java]   compileOnly group: "org.apache.cxf", name: "cxf-rt-frontend-jaxrs", version: "3.5.10]"
     [java]   compileOnly group...> but was:<...ore", version: "3.5.[9"
     [java]   compileOnly group: "org.apache.cxf", name: "cxf-rt-frontend-jaxrs", version: "3.5.9]"
     [java]   compileOnly group...>
     [java] 
     [java]   at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:472)
     [java]   at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:301)
[stopwatch] [run.batch.test.action: 3:00.366 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:498: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:651: Java returned: 1
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1129725707.properties

merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[beanshell] Truncating errors in /opt/dev/projects/github/liferay-portal/portal-impl/test-results/TEST-JenkinsLogAssertTest.xml

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null546549500

[junitreport] Loading stylesheet ile:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 326ms

[junitreport] Deleting: /tmp/null546549500

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-06-2025 09:36:11:360 PST

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Report:jenkins-report.html
Jenkins Suite:sf
Testray Routine:EE Pull Request
Testray Build ID:`130817184`

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 24 out of 25 jobs passed

❌ ci:test:relevant - 30 out of 101 jobs passed in 2 hours 39 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_6067

Base Branch:

Branch Name: master
Branch GIT ID: 20cac63d619b4803be9c429f00a285540558efeb

Upstream Comparison:

Branch GIT ID: 551dad365312e3592fd19eaabe2a0ca75d52fa62
Jenkins Build URL: EE Development Acceptance (master) - 1169 - 2025-02-06[00:36:11]

ci:test:stable - 24 out of 25 jobs PASSED

1 Failed Jobs:

24 Successful Jobs:
    ci:test:relevant - 30 out of 101 jobs PASSED

    71 Failed Jobs:

    30 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      6. ...
      Test bundle downloads:

      @liferay-continuous-integration
      Copy link
      Collaborator

      @liferay-continuous-integration
      Copy link
      Collaborator

      ❌ ci:test:headless - 99 out of 426 jobs passed in 2 hours 54 minutes

      Click here for more details.

      This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

      ci:reevaluate:1277401_13858

      Base Branch:

      Branch Name: master
      Branch GIT ID: 20cac63d619b4803be9c429f00a285540558efeb

      Upstream Comparison:

      Branch GIT ID: 551dad365312e3592fd19eaabe2a0ca75d52fa62
      Jenkins Build URL: EE Development Acceptance (master) - 1169 - 2025-02-06[00:36:11]

      ci:test:headless - 99 out of 426 jobs PASSED

      327 Failed Jobs:

      99 Successful Jobs:
        For more details click here.

        Failures unique to this pull:

        5. functional-tomcat90-mysql57/0/14
          record-testray-logs:
[beanshell] INFO: Using GOOGLE_APPLICATION_CREDENTIALS=/root/.gcloud/ci-testray.json
[beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/prepared_s3_logs
[beanshell] Unable to delete because file does not exist /opt/dev/projects/github/liferay-jenkins-ee/testray/recorded_logs
[beanshell] Created cache file in /tmp/jenkins-cached-files/686353788.txt
[beanshell] Executing commands: git remote -v
[beanshell] Found Git remotes: github-dev, origin, upstream
[beanshell] Created S3 Object https://storage.cloud.google.com/testray-results/2025-02/test-1-27/test-portal-acceptance-pullrequest(master)/13858/functional-tomcat90-mysql57/0/14/jenkins-console.txt.gz in 262 ms
[stopwatch] [run.current.job: 1:44.469 sec]
[beanshell] Created cache file in /tmp/jenkins-cached-files/686353788.txt

          BUILD FAILED
          
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:15408: The following error occurred while executing this line:
          
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:5866: The following error occurred while executing this line:
          
/opt/dev/projects/github/liferay-portal/build-test-batch.xml:1653: The following error occurred while executing this line:
          
/opt/dev/projects/github/liferay-portal/build-test.xml:15347: Warning: Could not find file /opt/dev/projects/github/liferay-portal/portal-web/test.generated.properties to copy.
        6. ...
        Test bundle downloads:

        @liferay-continuous-integration
        Copy link
        Collaborator

        @ccorreagg
        Copy link
        Collaborator Author

        ci:test:sf

        @ccorreagg
        Copy link
        Collaborator Author

        ci:test:relevant

        @ccorreagg
        Copy link
        Collaborator Author

        ci:test:headless

        @ccorreagg
        Copy link
        Collaborator Author

        ci:test:relevant

        @ccorreagg
        Copy link
        Collaborator Author

        ci:test:headless

        @liferay-continuous-integration
        Copy link
        Collaborator

        ❌ ci:test:stable - 24 out of 25 jobs passed

        ❌ ci:test:relevant - 80 out of 100 jobs passed in 3 hours 36 minutes

        Click here for more details.

        Base Branch:

        Branch Name: master
        Branch GIT ID: 444a3b6e689ca59285f1b62cb883883b7fc0fd47

        Upstream Comparison:

        Branch GIT ID: 3d27e5d3b5bb15e45b4b0008567bf2335616ee7d
        Jenkins Build URL: EE Development Acceptance (master) - 1181 - 2025-02-11[12:35:24]

        ci:test:stable - 24 out of 25 jobs PASSED

        1 Failed Jobs:

        24 Successful Jobs:
          ci:test:relevant - 80 out of 100 jobs PASSED

          20 Failed Jobs:

          80 Successful Jobs:
            For more details click here.

            Failures unique to this pull:

            1. rest-builder/0/0
                   [echo] index 9b6d2e53ff866..c9c9e82769af1 100644
     [echo] --- a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/site-test-entity.properties
     [echo] +++ b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/site-test-entity.properties
     [echo] @@ -7,6 +7,7 @@ batch.engine.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1
     [echo]  batch.engine.task.item.delegate=true
     [echo]  batch.planner.export.enabled=true
     [echo]  batch.planner.import.enabled=true
     [echo] +crud.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.SiteTestEntity
     [echo]  crud.item.delegate=true
     [echo]  entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.SiteTestEntity
     [echo]  osgi.jaxrs.application.select=(osgi.jaxrs.name=Liferay.Portal.Tools.REST.Builder.Test)
     [echo] diff --git a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] index 6a03e750df54c..ddfa4d3c3a7b1 100644
     [echo] --- a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] +++ b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] @@ -7,6 +7,7 @@ batch.engine.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1
     [echo]  batch.engine.task.item.delegate=true
     [echo]  batch.planner.export.enabled=true
     [echo]  batch.planner.import.enabled=true
     [echo] +crud.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.TestEntity
     [echo]  crud.item.delegate=true
     [echo]  entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.TestEntity
     [echo]  osgi.jaxrs.application.select=(osgi.jaxrs.name=Liferay.Portal.Tools.REST.Builder.Test)
[stopwatch] [run.batch.test.action: 42:34.465 sec]
     [echo] .
     [echo] 
     [echo] Detected build REST changes. See above build REST log for more
     [echo] information. Make sure to commit in all build REST results.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null111175384.properties
              1. com.liferay.jenkins.JenkinsLogAsserterTest
            Failures in common with acceptance upstream results at 3d27e5d:
            4. ...
            Test bundle downloads:

            @liferay-continuous-integration
            Copy link
            Collaborator

            ✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

            Click here for more details.

            Base Branch:

            Branch Name: master
            Branch GIT ID: c222c6b6d12ad896a0c8c2f16762ed68863f3ef3

            Sender Branch:

            Branch Name: LPD-47691-2
            Branch GIT ID: 620dd64c7f7c8ec34a968c177f999fa8959b11c0

            1 out of 1jobs PASSED
            1 Successful Jobs:
            For more details click here.

            @liferay-continuous-integration
            Copy link
            Collaborator

            Jenkins Report:jenkins-report.html
            Jenkins Suite:sf
            Testray Routine:EE Pull Request
            Testray Build ID:`136644945`

            @liferay-continuous-integration
            Copy link
            Collaborator

            @liferay-continuous-integration
            Copy link
            Collaborator

            ❌ ci:test:headless - 378 out of 426 jobs passed in 2 hours 52 minutes

            Click here for more details.

            Base Branch:

            Branch Name: master
            Branch GIT ID: 444a3b6e689ca59285f1b62cb883883b7fc0fd47

            Upstream Comparison:

            Branch GIT ID: 3d27e5d3b5bb15e45b4b0008567bf2335616ee7d
            Jenkins Build URL: EE Development Acceptance (master) - 1181 - 2025-02-11[12:35:24]

            ci:test:headless - 378 out of 426 jobs PASSED

            48 Failed Jobs:

            378 Successful Jobs:
              For more details click here.

              Failures unique to this pull:

              6. ...
              Test bundle downloads:

              @liferay-continuous-integration
              Copy link
              Collaborator

              @liferay-continuous-integration
              Copy link
              Collaborator

              ❌ ci:test:headless - 395 out of 426 jobs passed in 2 hours 35 minutes

              Click here for more details.

              This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

              ci:reevaluate:1367401_7292

              Base Branch:

              Branch Name: master
              Branch GIT ID: c222c6b6d12ad896a0c8c2f16762ed68863f3ef3

              Upstream Comparison:

              Branch GIT ID: 3d27e5d3b5bb15e45b4b0008567bf2335616ee7d
              Jenkins Build URL: EE Development Acceptance (master) - 1181 - 2025-02-11[12:35:24]

              ci:test:headless - 395 out of 426 jobs PASSED

              31 Failed Jobs:

              395 Successful Jobs:
                For more details click here.

                Failures unique to this pull:

                6. ...
                Test bundle downloads:

                @liferay-continuous-integration
                Copy link
                Collaborator

                @liferay-continuous-integration
                Copy link
                Collaborator

                ❌ ci:test:stable - 24 out of 25 jobs passed

                ❌ ci:test:relevant - 78 out of 101 jobs passed in 2 hours 46 minutes

                Click here for more details.

                This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

                ci:reevaluate:1277401_13892

                Base Branch:

                Branch Name: master
                Branch GIT ID: c222c6b6d12ad896a0c8c2f16762ed68863f3ef3

                Upstream Comparison:

                Branch GIT ID: 3d27e5d3b5bb15e45b4b0008567bf2335616ee7d
                Jenkins Build URL: EE Development Acceptance (master) - 1181 - 2025-02-11[12:35:24]

                ci:test:stable - 24 out of 25 jobs PASSED

                1 Failed Jobs:

                24 Successful Jobs:
                  ci:test:relevant - 78 out of 101 jobs PASSED

                  23 Failed Jobs:

                  78 Successful Jobs:
                    For more details click here.

                    Failures unique to this pull:

                    1. rest-builder/0/0
                           [echo] index 9b6d2e53ff866..c9c9e82769af1 100644
     [echo] --- a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/site-test-entity.properties
     [echo] +++ b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/site-test-entity.properties
     [echo] @@ -7,6 +7,7 @@ batch.engine.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1
     [echo]  batch.engine.task.item.delegate=true
     [echo]  batch.planner.export.enabled=true
     [echo]  batch.planner.import.enabled=true
     [echo] +crud.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.SiteTestEntity
     [echo]  crud.item.delegate=true
     [echo]  entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.SiteTestEntity
     [echo]  osgi.jaxrs.application.select=(osgi.jaxrs.name=Liferay.Portal.Tools.REST.Builder.Test)
     [echo] diff --git a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] index 6a03e750df54c..ddfa4d3c3a7b1 100644
     [echo] --- a/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] +++ b/modules/util/portal-tools-rest-builder-test-impl/src/main/resources/OSGI-INF/liferay/rest/v1_0/test-entity.properties
     [echo] @@ -7,6 +7,7 @@ batch.engine.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1
     [echo]  batch.engine.task.item.delegate=true
     [echo]  batch.planner.export.enabled=true
     [echo]  batch.planner.import.enabled=true
     [echo] +crud.entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.TestEntity
     [echo]  crud.item.delegate=true
     [echo]  entity.class.name=com.liferay.portal.tools.rest.builder.test.dto.v1_0.TestEntity
     [echo]  osgi.jaxrs.application.select=(osgi.jaxrs.name=Liferay.Portal.Tools.REST.Builder.Test)
[stopwatch] [run.batch.test.action: 35:17.995 sec]
     [echo] .
     [echo] 
     [echo] Detected build REST changes. See above build REST log for more
     [echo] information. Make sure to commit in all build REST results.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null2123905574.properties
                      1. com.liferay.jenkins.JenkinsLogAsserterTest
                    Failures in common with acceptance upstream results at 3d27e5d:
                    2. ...
                    Test bundle downloads:

                    @liferay-continuous-integration
                    Copy link
                    Collaborator

                    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
                    Reviewers

                    @liferay-headless liferay-headless Awaiting requested review from liferay-headless liferay-headless is a code owner

                    Assignees
                    No one assigned
                    Labels
                    ci:test:headless - failure ci:test:relevant - failure ci:test:sf - success ci:test:stable - failure
                    Projects
                    None yet
                    Milestone
                    No milestone
                    Development

                    Successfully merging this pull request may close these issues.
                    4 participants
                    @ccorreagg @liferay-continuous-integration @marco-leo @4lejandrito