Adding webpack 4 in the build process, upgrading to React 16.3.1 and removing support for IE 9 and 10 #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplifies build step (webpack) - Removes UI layers and keeps only react - Updates to react 16
It will be absolute to use the gulp in the next changes.
TODO: We are altering the direct basePath of the CKEDITOR object so that it works with the final bundle, we still have to analyze if it is the ideal one.
TODO: Let's consider removing this in the near future.
…re already in the AlloyEditor API
…the tests since we already have in the main
matuzalemsteles
changed the title
|
This looks like an awesome starting point, @matuzalemsteles! I'm merging this in so we can continue on top of it. There are some concerns regarding CKEditor License change, so we might need to stick with |
|
I've merged this into Great job @matuzalemsteles !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
transform-class-propertiesforstaticuse in classChanges
React.addons.TestUtilswithreact-dom/test-utilsBreakings
AlloyEditor.ButtonBoldwill causeundefinedfor example. We continue withAlloyEditor.Buttons[...key].Notes
Components
Made minor changes to some components, see ff816fe, f66fda1, 3d7633e...
Tests
Many of the tests have been set to work again with the new build process, some changes consist of
importsof files or mocks of functions.Skip some test
Ref: 4ecd00c
It was necessary to pass some tests since the UIBRIDGE components have not yet been refactored and are having problems with findAllInRenderedTree and isCompositeComponentWithType.
Use gulp for generate files
For a moment we are maintaining the use of gulp to generate the css files, icon fonts, copy files from CKEDITOR, languages and generate the demo. In the near future we will be able to remove the gulp by scripts next to the Webpack.
Insights
CI
Test run times averaged 4 min compared to 7 min. 🙂
Bundle
With the new build process with webpack 4, the size of some of our packages have remained the same and others have increased because of things the webpack ends up adding to create the wrapper or adding polyfill if necessary.
New structure
dist/- Build Fileslib/- CKEditor Filesscripts/- Build-related scripts and utilities for testing.src/- All code base, Core, Plugins and UItest/- All of our tests togetherpackage.json- npm module manifestFuture
Our structure still needs refinements, but we need to work on our code base to continue polishing architecture over time.
create-react-classcomponentWillMount,componentWillReceivePropsandcomponentWillUpdate.