Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile error with clay-css scss #1220

Closed
matuzalemsteles opened this issue Oct 3, 2018 · 0 comments
Closed

Compile error with clay-css scss #1220

matuzalemsteles opened this issue Oct 3, 2018 · 0 comments
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@matuzalemsteles
Copy link
Member

I've been trying to build 'build` from clayui.com but are getting the scss compilation error for the clay-css files:

0.5rem + 0.0625rem 0.0625rem 0.0625rem 
 -------------------^
  Expecting 'EOF', 'ADD', 'SUB', 'MUL', 'DIV', 'RPAREN', got 'REMS'

I went to investigate and it looks like we're using the wrong variables at https://github.com/liferay/clay/blob/master/packages/clay-css/src/scss/bootstrap/_forms.scss#L89-L109. It seems related to that #1126.
@matuzalemsteles matuzalemsteles added the type: bug Issues reporting that Component is not doing what should be done label Oct 3, 2018
jbalsas added a commit that referenced this issue Oct 3, 2018
@jbalsas
Workaround #1220
0bf32aa
jbalsas added a commit that referenced this issue Oct 16, 2018
@jbalsas
Merge pull request #1234 from pat270/clay-1220
3fb85ac 
Fixes #1220 - Use `$input-border-width` the same way Bootstrap uses it
@pat270 pat270 added the status: next-release Issues that will enter into the next release label Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pat270 @matuzalemsteles