Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management toolbar mobile viewports Clear action must be right aligned #1226

Closed
victorvalle opened this issue Oct 9, 2018 · 11 comments
Closed
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) comp: clay-css Issues related to Clay CSS status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@victorvalle
Copy link

The aligntment of the clear action should be right.
This action is now aligned next to the text

image

Please see: https://liferay.invisionapp.com/share/PVN3QSTHK65#/312223170_0604m

Do not modify other styling things, please.

@matuzalemsteles
Copy link
Member

matuzalemsteles commented Oct 9, 2018

hey @pat270, this seems to look like this when it's a smaller screen. Can you check this?

@pat270
Copy link
Member

pat270 commented Nov 20, 2018

@matuzalemsteles @victorvalle You can use the class tbar-inline-sm-down to make it align right on screen sizes >= 768px. tbar-inline-md-down align right screen size >= 992px.

@victorvalle
Copy link
Author

@pat270 @matuzalemsteles I see that the documentation says

In viewports under 576px, the "Clear All" button is no longer anchored to the right of the component and is placed inline just after the last element of the information.

And then there is a comment from Patrick asking

Can we just have this component behave this way in all screens? I'm running into css/html limitations where I can get it to behave like desktop, but cant get it to work in mobile without moving the button markup.

Do you still have this limitation?
It is a bit strange for us to have it so close in Desktop. But is this happens we can study a solution.
Maybe @atjuan has thought about it further.

@pat270
Copy link
Member

pat270 commented Nov 20, 2018

@victorvalle technically there is. I wasn't able to get it to break/align exactly like the mockups, but I got pretty close. All the classes that are available are:

tbar-inline-xs-down (inline at max-width 575px)
tbar-inline-sm-down (inline at max-width 767px)
tbar-inline-md-down (inline at max-width 991px)
tbar-inline-lg-down (inline at max-width 1199px)
tbar-inline-xl-down (inline at all screens probably should have named this something else)

@victorvalle
Copy link
Author

Hi @pat270,
I see this right now:
350px
image

575px
image

767px
image

991px
image

1199px
image

I guess we could live with the solution as we see it right now. It is a really good approach to what we want.

@pat270
Copy link
Member

pat270 commented Nov 21, 2018

@victorvalle if you manually change the class on the blue bar from tbar-inline-md-down to tbar-inline-xs-down you can see it becomes inline at 575px, maybe we can add an option to specify the breakpoint in the plugin?

@matuzalemsteles matuzalemsteles added type: bug Issues reporting that Component is not doing what should be done comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) comp: clay-css Issues related to Clay CSS labels Nov 23, 2018
@matuzalemsteles
Copy link
Member

hey @pat270, @victorvalle how do we proceed with this?

@pat270
Copy link
Member

pat270 commented Dec 6, 2018

@matuzalemsteles @victorvalle The rules between the invision link and google documentation is conflicting. The only thing is to allow devs to set the tbar-inline-*-down class so they can take it case by case.

@matuzalemsteles
Copy link
Member

thanks @pat270, so we should leave the tbar-inline-md-down as the default, correct? I'll follow through with this and send a PR adding an API that reflects this setting.

matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 7, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 7, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 7, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 7, 2018
@pat270
Copy link
Member

pat270 commented Dec 7, 2018

@matuzalemsteles maybe tbar-inline-xs-down is better by default. The Clear All button will at least be aligned right in most screens when there is little content.

matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue Dec 11, 2018
jbalsas added a commit that referenced this issue Dec 12, 2018
 Fixes #1226 - Replace tbar-inline-md-down with tbar-inline-xs-down
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) comp: clay-css Issues related to Clay CSS status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

3 participants