Failed to render when string is passed to geomap data

[matuzalemsteles]

Hey @julien, it seems to fail when I try to pass a string in the data, it manages to do the Fetch but in DataComponent._resolveData it expects it to come inside a data and arrives {"type":"FeatureCollection","features"....

return fetch(data, {cors: 'cors'})
	.then(res => res.json())
	.then(res => res.data);

https://github.com/liferay/clay/blob/master/packages/clay-charts/src/DataComponent.js#L38

He ends up giving an error soon after:

const features = mapData.features;

https://github.com/liferay/clay/blob/master/packages/clay-charts/src/Geomap.js#L150

It works fine when I change .then(res => res.data); for then(res => res);, but I do not know if it is expected.

I'm using data from world-low-res.geo.json

[julien]

Hey @matuzalemsteles this is not a bug, it's a feature ;)

Jokes aside, the reason for this is that DataComponent is used by ChartBase and Geomap, and ChartBase expects the data to be in a data property.

If you update you geojson file to have a data field it will load properly, I had to fix this in portal too last week.

Tell me if you need any help.

[matuzalemsteles]

Thanks for the clarifications @julien, it looks better now.

I'll just update this to be included in data so can work properly. I'm just looking at the geomap being rendered on clayui.com.

[julien]

Ok thanks @matuzalemsteles

[matuzalemsteles]

Closing this, since the problem has been solved.