Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bar is not passed to the Billboard in ChartBase and the validations are incorrect #903

Closed
matuzalemsteles opened this issue May 17, 2018 · 0 comments
Assignees
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done

Comments

@matuzalemsteles
Copy link
Member

matuzalemsteles commented May 17, 2018

Summary

ClayCharts does not pass the bar API to the Billboard and the validations are incorrect according to the Billboard documentation.

Current API

bar: Config.shapeOf({
	width: Config.number(),
	zerobased: Config.bool(),
}),

Expected API behavior

bar: Config.shapeOf({
	width: Config.oneOfType([
		Config.number(),
		Config.shapeOf({
			max: Config.number(),
			ratio: Config.number(),
		}),
	]),
	padding: Config.number(),
	zerobased: Config.bool(),
 }),
@matuzalemsteles matuzalemsteles added the type: bug Issues reporting that Component is not doing what should be done label May 17, 2018
@matuzalemsteles matuzalemsteles self-assigned this May 17, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 17, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 17, 2018
matuzalemsteles added a commit to matuzalemsteles/clay that referenced this issue May 17, 2018
jbalsas added a commit that referenced this issue May 17, 2018
Fix bar API validations and passed to the Billboard | Fixes #903
@matuzalemsteles matuzalemsteles added the status: next-release Issues that will enter into the next release label May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: next-release Issues that will enter into the next release type: bug Issues reporting that Component is not doing what should be done
Projects
None yet
Development

No branches or pull requests

1 participant