Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes default tooltip position as Bottom to Top #1096

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

boton
Copy link
Member

@boton boton commented Aug 16, 2018

No description provided.

@boton boton changed the base branch from master to develop August 16, 2018 08:26
@boton boton changed the title Update jest snapshots | Related #1082 Changes default tooltip position as Bottom to Top | Fixes #1082 Aug 16, 2018
@boton boton changed the title Changes default tooltip position as Bottom to Top | Fixes #1082 Changes default tooltip position as Bottom to Top Aug 16, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1078

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 80.664%

Files with Coverage Reduction New Missed Lines %
packages/generator-metal-clay/app/index.js 25 15.0%
Totals Coverage Status
Change from base Build 1068: -0.3%
Covered Lines: 5106
Relevant Lines: 5509

💛 - Coveralls

@julien
Copy link
Contributor

julien commented Aug 16, 2018

Just started reviewing :)

:octocat: Sent from GH.

@julien
Copy link
Contributor

julien commented Aug 16, 2018

Hey @boton ,

I checked your pull request and everything looks fine.

Before merging it though, I'd like to know what @victorvalle, @marcoscv and @pat270 think about this change.

@pat270
Copy link
Member

pat270 commented Aug 16, 2018

@julien, I agree with @boton. I like tooltips top by default better. It seems like the most common use case in portal.

@julien
Copy link
Contributor

julien commented Aug 16, 2018

@pat270 thanks for the feedback!

@victorvalle
Copy link

I'm ok with this change as said in the other issue :)

@carloslancha
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@carloslancha carloslancha merged commit 5dcb0dd into liferay:develop Aug 20, 2018
@boton boton deleted the issue-1082 branch April 9, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants